[FastTextAutosizing] Remove FastTextAutosizer::enabled

[FastTextAutosizing] Remove FastTextAutosizer::enabled

FastTextAutosizer::enabled() is hot on profiles as it's called multiple
times per block. The places where the text autosizing setting can
change are well defined and all go through updatePageInfo() so this
patch removes enabled() entirely, replacing it with a check of
m_pageInfo.m_settingEnabled which is updated in updatePageInfo().

This patch is a followup to
https://src.chromium.org/viewvc/blink?view=rev&revision=173020

No new tests as this is just a refactoring.

BUG=367864
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173042

[skobes, 2014-04-30 22:56:39]

lgtm

https://codereview.chromium.org/265713002/diff/1/Source/core/rendering/FastTe...
File Source/core/rendering/FastTextAutosizer.cpp (right):

https://codereview.chromium.org/265713002/diff/1/Source/core/rendering/FastTe...
Source/core/rendering/FastTextAutosizer.cpp:470: ASSERT(!(m_document->settings()
&& m_document->settings()->textAutosizingEnabled()) ||
m_document->frame()->isMainFrame());
The reason this had !enabled() was to avoid blowing up if frame() returned null.

To best express the intent I would write it as:
    ASSERT(!m_document->frame() || m_document->frame()->isMainFrame());

[pdr., 2014-04-30 23:12:03]

https://codereview.chromium.org/265713002/diff/1/Source/core/rendering/FastTe...
File Source/core/rendering/FastTextAutosizer.cpp (right):

https://codereview.chromium.org/265713002/diff/1/Source/core/rendering/FastTe...
Source/core/rendering/FastTextAutosizer.cpp:470: ASSERT(!(m_document->settings()
&& m_document->settings()->textAutosizingEnabled()) ||
m_document->frame()->isMainFrame());
On 2014/04/30 22:56:40, skobes wrote:
> The reason this had !enabled() was to avoid blowing up if frame() returned
null.
> 
> To best express the intent I would write it as:
>     ASSERT(!m_document->frame() || m_document->frame()->isMainFrame());

Ahh, I was really not sure what this was doing. This makes much more sense.
Done.

[pdr., 2014-04-30 23:12:08]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2014-04-30 23:12:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pdr@chromium.org/265713002/20001

[commit-bot: I haz the power, 2014-05-01 00:15:08]

Change committed as 173042