Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: BUILD.gn

Issue 2657123002: Revert "Create an app snapshot of the Dart front end." (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 8f6dcf83cd8ed2a8e7b58c35bbbd4c67211b98f1..033a324397de2a3fc69b67f9d1ca583f68e80549 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -43,12 +43,6 @@ group("runtime") {
"runtime/bin:test_extension",
"runtime/vm:patched_sdk",
]
-
- # TODO(28532): Enable on Windows.
- # TODO(rmacnak): Link this into 'dart'
- if (target_os != "windows") {
- deps += [ "utils/kernel-service:kernel-service" ]
- }
}
group("runtime_precompiled") {
@@ -128,7 +122,9 @@ action("create_sdk") {
rebase_path("$root_gen_dir"),
]
if (defined(is_fuchsia) && is_fuchsia_host) {
- args += [ "--copy_libs" ]
+ args += [
+ "--copy_libs"
+ ]
}
}
@@ -177,10 +173,11 @@ group("samples") {
]
}
+
# The rules below build a qemu Fuchsia OS image that includes the Dart tree
# under /system/test/dart. Building this image is gated by the GN argument
# 'dart_build_fuchsia_test_image' because building the image is slow.
-if (defined(is_fuchsia) && is_fuchsia) {
+if (defined(is_fuchsia) && (is_fuchsia)) {
declare_args() {
dart_build_fuchsia_test_image = false
}
@@ -220,10 +217,10 @@ if (defined(is_fuchsia) && is_fuchsia) {
action("generate_dart_test_image") {
testonly = true
deps = [
- ":generate_dart_test_manifest",
"runtime/bin:dart",
- "runtime/bin:process_test",
"runtime/bin:run_vm_tests",
+ "runtime/bin:process_test",
+ ":generate_dart_test_manifest",
]
input = "$target_gen_dir/dart_test_tree.manifest"
« no previous file with comments | « no previous file | runtime/bin/main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698