Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: dashboard/dashboard/elements/speed-releasing-table.html

Issue 2657043002: Handles default revision ranges. (Closed)
Patch Set: Fixing minor bug Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dashboard/dashboard/elements/speed-releasing-table.html
diff --git a/dashboard/dashboard/elements/speed-releasing-table.html b/dashboard/dashboard/elements/speed-releasing-table.html
index 9f15451ece497bd57dc8173a0e002c1ecbe188ee..d28902974c11ce95ffdf9b8822de525cdaf9de68 100644
--- a/dashboard/dashboard/elements/speed-releasing-table.html
+++ b/dashboard/dashboard/elements/speed-releasing-table.html
@@ -60,12 +60,15 @@ found in the LICENSE file.
<table id="speed-releasing">
<thead>
<tr>
- <th colspan="2"></th>
- <template is="dom-repeat" items="{{tableConfig.revisions}}"
+ <th colspan="2" rowspan="1"></th>
+ <template is="dom-repeat"
+ items="{{tableConfig.displayRevisions}}"
as="rev">
- <th>Version: {{rev}}</th>
+ <th colspan="1">
+ {{getCurrOrRef(index)}} Version: {{rev}}
+ </th>
</template>
- <th colspan="4">Change</th>
+ <th colspan="2">Change</th>
</tr>
</thead>
<template is="dom-repeat" items="{{tableConfig.tests}}"
@@ -124,6 +127,10 @@ found in the LICENSE file.
},
},
+ getCurrOrRef: function(index) {
+ return index ? 'Reference' : 'Current';
+ },
+
/**
* Gets the specified value given a rev, bot, test.
*/
@@ -215,6 +222,7 @@ found in the LICENSE file.
this.tableConfig.revisions = response['revisions'];
this.tableConfig.units = response['units'];
this.tableConfig.categories = response['categories'];
+ this.tableConfig.displayRevisions = response['display_revisions'];
this.loading = false;
}.bind(this),
function(msg) {
« no previous file with comments | « no previous file | dashboard/dashboard/elements/speed-releasing-table-test.html » ('j') | dashboard/dashboard/speed_releasing.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698