Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4340)

Unified Diff: chrome/browser/extensions/api/spellcheck/spellcheck_api.cc

Issue 265703011: cleanup: pass string as const reference from c/b/extension/api (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/spellcheck/spellcheck_api.cc
diff --git a/chrome/browser/extensions/api/spellcheck/spellcheck_api.cc b/chrome/browser/extensions/api/spellcheck/spellcheck_api.cc
index 3f88362d775a817b97e54ddc712b2281f4d112d1..56e4d658614f16da98b049b4e114a2221ad83f7e 100644
--- a/chrome/browser/extensions/api/spellcheck/spellcheck_api.cc
+++ b/chrome/browser/extensions/api/spellcheck/spellcheck_api.cc
@@ -25,7 +25,8 @@ SpellcheckDictionaryInfo* GetSpellcheckDictionaryInfo(
return spellcheck_info;
}
-SpellcheckService::DictionaryFormat GetDictionaryFormat(std::string format) {
+SpellcheckService::DictionaryFormat GetDictionaryFormat(
+ const std::string& format) {
if (format == "hunspell") {
return SpellcheckService::DICT_HUNSPELL;
} else if (format == "text") {

Powered by Google App Engine
This is Rietveld 408576698