chrome/browser/extensions/api/file_system/file_system_api_unittest.cc - Issue 265703011: cleanup: pass string as const reference from c/b/extension/api

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/file_system/file_system_api_unittest.cc

Issue 265703011: cleanup: pass string as const reference from c/b/extension/api (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/developer_private/developer_private_api.cc ('k') | chrome/browser/extensions/api/image_writer_private/removable_storage_provider_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/file_system/file_system_api_unittest.cc

diff --git a/chrome/browser/extensions/api/file_system/file_system_api_unittest.cc b/chrome/browser/extensions/api/file_system/file_system_api_unittest.cc

index ba2fd953de14ea090e9260c84f2269fbbcee2e69..29ed35c90a6156da142413ee2372a803f4a6ddeb 100644

--- a/chrome/browser/extensions/api/file_system/file_system_api_unittest.cc

+++ b/chrome/browser/extensions/api/file_system/file_system_api_unittest.cc

@@ -25,9 +25,9 @@ void CheckExtensions(const std::vector<base::FilePath::StringType>& expected,

}

-AcceptOption* BuildAcceptOption(std::string description,

- std::string mime_types,

- std::string extensions) {

+AcceptOption* BuildAcceptOption(const std::string& description,

+ std::string mime_types,

Devlin 2014/05/02 15:34:15 why not also make the other two params const &?

limasdf 2014/05/02 16:26:46 Done. I dont know why-_- I didn't

+ std::string extensions) {

AcceptOption* option = new AcceptOption();

if (!description.empty())