Cleanup AppInfoPermissionsTabTest

Fixed AppInfoPermissionsTabTest to use correct EXPECTs and ASSERTs

To help make test results more informative, updated AppInfoPermissionsTabTest to
use EXPECT and ASSERT in appropriate places. Future test failures will now halt
or continue correctly depending on the failed check.

Also added other minor cleanups to make the test easier to read/maintain.

BUG=368758
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267966

[Lei Zhang, 2014-05-02 18:57:54]

lgtm

You forgot to send this out for review.

https://codereview.chromium.org/265703010/diff/20001/chrome/browser/ui/views/...
File
chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab_unittest.cc
(right):

https://codereview.chromium.org/265703010/diff/20001/chrome/browser/ui/views/...
chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_tab_unittest.cc:90:
.Append("notifications")  // An valid permission with
you've changed the permissions here and below in the other test cases. I assume
this is to pick permissions that are available on all channels?

[commit-bot: I haz the power, 2014-05-02 18:58:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sashab@chromium.org/265703010/20001

[commit-bot: I haz the power, 2014-05-02 19:27:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-02 19:27:28]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium

[Lei Zhang, 2014-05-02 21:30:36]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-05-02 21:31:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sashab@chromium.org/265703010/20001

[commit-bot: I haz the power, 2014-05-02 23:28:44]

Change committed as 267966