Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: tools/gn/ninja_target_writer_unittest.cc

Issue 265703008: Support deps for actions in GN. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_target_writer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/ninja_target_writer_unittest.cc
diff --git a/tools/gn/ninja_target_writer_unittest.cc b/tools/gn/ninja_target_writer_unittest.cc
index d542147458c1d12d2db82554621ddaff9c79aad2..6954cfaf86fb8a6f78a98b5b9dcf14b4a90ab953 100644
--- a/tools/gn/ninja_target_writer_unittest.cc
+++ b/tools/gn/ninja_target_writer_unittest.cc
@@ -21,8 +21,9 @@ class TestingNinjaTargetWriter : public NinjaTargetWriter {
virtual void Run() OVERRIDE {}
// Make this public so the test can call it.
- std::string WriteInputDepsStampAndGetDep() {
- return NinjaTargetWriter::WriteInputDepsStampAndGetDep();
+ std::string WriteInputDepsStampAndGetDep(
+ const std::vector<const Target*>& extra_hard_deps) {
+ return NinjaTargetWriter::WriteInputDepsStampAndGetDep(extra_hard_deps);
}
};
@@ -58,7 +59,8 @@ TEST(NinjaTargetWriter, WriteInputDepsStampAndGetDep) {
{
std::ostringstream stream;
TestingNinjaTargetWriter writer(&base_target, setup.toolchain(), stream);
- std::string dep = writer.WriteInputDepsStampAndGetDep();
+ std::string dep =
+ writer.WriteInputDepsStampAndGetDep(std::vector<const Target*>());
EXPECT_TRUE(dep.empty());
EXPECT_TRUE(stream.str().empty());
@@ -68,7 +70,8 @@ TEST(NinjaTargetWriter, WriteInputDepsStampAndGetDep) {
{
std::ostringstream stream;
TestingNinjaTargetWriter writer(&target, setup.toolchain(), stream);
- std::string dep = writer.WriteInputDepsStampAndGetDep();
+ std::string dep =
+ writer.WriteInputDepsStampAndGetDep(std::vector<const Target*>());
EXPECT_EQ(" | obj/foo/target.inputdeps.stamp", dep);
EXPECT_EQ("obj/foo/target.inputdeps.stamp: stamp "
@@ -81,7 +84,8 @@ TEST(NinjaTargetWriter, WriteInputDepsStampAndGetDep) {
{
std::ostringstream stream;
TestingNinjaTargetWriter writer(&action, setup.toolchain(), stream);
- std::string dep = writer.WriteInputDepsStampAndGetDep();
+ std::string dep =
+ writer.WriteInputDepsStampAndGetDep(std::vector<const Target*>());
EXPECT_EQ(" | obj/foo/action.inputdeps.stamp", dep);
EXPECT_EQ("obj/foo/action.inputdeps.stamp: stamp "
« no previous file with comments | « tools/gn/ninja_target_writer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698