Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: chrome/test/remoting/webapp_javascript_browsertest.cc

Issue 2657023003: Disable Remoting_Webapp_Js_Unittest on ASAN due to flake. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/remoting/webapp_javascript_browsertest.cc
diff --git a/chrome/test/remoting/webapp_javascript_browsertest.cc b/chrome/test/remoting/webapp_javascript_browsertest.cc
index f8b2e68f7a1491dde1867b6e8c1069f497af465a..b70e3546ebe4336cc41891cc1b512c4f03619bbb 100644
--- a/chrome/test/remoting/webapp_javascript_browsertest.cc
+++ b/chrome/test/remoting/webapp_javascript_browsertest.cc
@@ -14,7 +14,8 @@ namespace remoting {
// Disable test on (dbg) as it takes longer than 30s to complete.
// https://crbug.com/504204.
-#if (!defined(NDEBUG))
+// Also disable on ASAN due to flake: crbug.com/685025
+#if !defined(NDEBUG) || defined(ADDRESS_SANITIZER)
#define MAYBE_Remoting_Webapp_Js_Unittest DISABLED_Remoting_Webapp_Js_Unittest
#else
#define MAYBE_Remoting_Webapp_Js_Unittest Remoting_Webapp_Js_Unittest
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698