Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3970)

Unified Diff: chrome/browser/android/offline_pages/recent_tab_helper.cc

Issue 2657013002: Introduce ThreadTaskRunnerHandle::OverrideForTesting and TestMockTimeTaskRunner::ScopedContext. (Closed)
Patch Set: fix RecentTabHelperTest crash? Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/recent_tab_helper.cc
diff --git a/chrome/browser/android/offline_pages/recent_tab_helper.cc b/chrome/browser/android/offline_pages/recent_tab_helper.cc
index 064036a99e7e317547e6a0e54f26aa1db79d0b4a..1f7cad968b25e277c88f2fcabf2c49e16787ecc6 100644
--- a/chrome/browser/android/offline_pages/recent_tab_helper.cc
+++ b/chrome/browser/android/offline_pages/recent_tab_helper.cc
@@ -44,9 +44,6 @@ class DefaultDelegate: public offline_pages::RecentTabHelper::Delegate {
return base::MakeUnique<offline_pages::OfflinePageMHTMLArchiver>(
web_contents);
}
- scoped_refptr<base::SingleThreadTaskRunner> GetTaskRunner() override {
- return base::ThreadTaskRunnerHandle::Get();
- }
bool GetTabId(content::WebContents* web_contents, int* tab_id) override {
return offline_pages::OfflinePageUtils::GetTabId(web_contents, tab_id);
}
@@ -167,7 +164,7 @@ bool RecentTabHelper::EnsureInitialized() {
return snapshots_enabled_;
snapshot_controller_.reset(
- new SnapshotController(delegate_->GetTaskRunner(), this));
+ new SnapshotController(base::ThreadTaskRunnerHandle::Get(), this));
snapshot_controller_->Stop(); // It is reset when navigation commits.
int tab_id_number = 0;

Powered by Google App Engine
This is Rietveld 408576698