Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: base/threading/thread_task_runner_handle.cc

Issue 2657013002: Introduce ThreadTaskRunnerHandle::OverrideForTesting and TestMockTimeTaskRunner::ScopedContext. (Closed)
Patch Set: fix RecentTabHelperTest crash? Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/threading/thread_task_runner_handle.h" 5 #include "base/threading/thread_task_runner_handle.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h"
9 #include "base/lazy_instance.h" 10 #include "base/lazy_instance.h"
10 #include "base/logging.h" 11 #include "base/logging.h"
12 #include "base/memory/ptr_util.h"
11 #include "base/threading/sequenced_task_runner_handle.h" 13 #include "base/threading/sequenced_task_runner_handle.h"
12 #include "base/threading/thread_local.h" 14 #include "base/threading/thread_local.h"
13 15
14 namespace base { 16 namespace base {
15 17
16 namespace { 18 namespace {
17 19
18 base::LazyInstance<base::ThreadLocalPointer<ThreadTaskRunnerHandle>>::Leaky 20 base::LazyInstance<base::ThreadLocalPointer<ThreadTaskRunnerHandle>>::Leaky
19 lazy_tls_ptr = LAZY_INSTANCE_INITIALIZER; 21 lazy_tls_ptr = LAZY_INSTANCE_INITIALIZER;
20 22
21 } // namespace 23 } // namespace
22 24
23 // static 25 // static
24 scoped_refptr<SingleThreadTaskRunner> ThreadTaskRunnerHandle::Get() { 26 scoped_refptr<SingleThreadTaskRunner> ThreadTaskRunnerHandle::Get() {
25 ThreadTaskRunnerHandle* current = lazy_tls_ptr.Pointer()->Get(); 27 ThreadTaskRunnerHandle* current = lazy_tls_ptr.Pointer()->Get();
26 DCHECK(current); 28 DCHECK(current);
27 return current->task_runner_; 29 return current->task_runner_;
28 } 30 }
29 31
30 // static 32 // static
31 bool ThreadTaskRunnerHandle::IsSet() { 33 bool ThreadTaskRunnerHandle::IsSet() {
32 return !!lazy_tls_ptr.Pointer()->Get(); 34 return !!lazy_tls_ptr.Pointer()->Get();
33 } 35 }
34 36
37 // static
38 ScopedClosureRunner ThreadTaskRunnerHandle::OverrideForTesting(
39 scoped_refptr<SingleThreadTaskRunner> overriding_task_runner) {
40 // OverrideForTesting() is not compatible with a SequencedTaskRunnerHandle
41 // being set (but SequencedTaskRunnerHandle::IsSet() includes
42 // ThreadTaskRunnerHandle::IsSet() so that's discounted as the only valid
43 // excuse for it to be true). Sadly this means that tests that merely need a
44 // SequencedTaskRunnerHandle on their main thread can be forced to use a
45 // ThreadTaskRunnerHandle if they're also using test task runners (that
46 // OverrideForTesting() when running their tasks from said main thread). To
47 // solve this: sequence_task_runner_handle.cc and thread_task_runner_handle.cc
48 // would have to be merged into a single impl file and share TLS state. This
49 // was deemed unecessary for now as most tests should use higher level
50 // constructs and not have to instantiate task runner handles on their own.
51 DCHECK(!SequencedTaskRunnerHandle::IsSet() || IsSet());
52
53 if (!IsSet()) {
54 std::unique_ptr<ThreadTaskRunnerHandle> top_level_ttrh =
55 MakeUnique<ThreadTaskRunnerHandle>(std::move(overriding_task_runner));
56 return ScopedClosureRunner(base::Bind(
57 [](std::unique_ptr<ThreadTaskRunnerHandle> ttrh_to_release) {},
58 base::Passed(&top_level_ttrh)));
59 }
60
61 ThreadTaskRunnerHandle* ttrh = lazy_tls_ptr.Pointer()->Get();
62 // Swap the two (and below bind |overriding_task_runner|, which is now the
63 // previous one, as the |task_runner_to_restore|).
64 ttrh->task_runner_.swap(overriding_task_runner);
65
66 return ScopedClosureRunner(base::Bind(
67 [](scoped_refptr<SingleThreadTaskRunner> task_runner_to_restore,
68 SingleThreadTaskRunner* expected_task_runner_before_restore) {
69 ThreadTaskRunnerHandle* ttrh = lazy_tls_ptr.Pointer()->Get();
70
71 DCHECK_EQ(expected_task_runner_before_restore, ttrh->task_runner_.get())
72 << "Nested overrides must expire their ScopedClosureRunners "
73 "in LIFO order.";
74
75 ttrh->task_runner_.swap(task_runner_to_restore);
76 },
77 base::Passed(&overriding_task_runner),
78 base::Unretained(ttrh->task_runner_.get())));
79 }
80
35 ThreadTaskRunnerHandle::ThreadTaskRunnerHandle( 81 ThreadTaskRunnerHandle::ThreadTaskRunnerHandle(
36 scoped_refptr<SingleThreadTaskRunner> task_runner) 82 scoped_refptr<SingleThreadTaskRunner> task_runner)
37 : task_runner_(std::move(task_runner)) { 83 : task_runner_(std::move(task_runner)) {
38 DCHECK(task_runner_->BelongsToCurrentThread()); 84 DCHECK(task_runner_->BelongsToCurrentThread());
39 // No SequencedTaskRunnerHandle (which includes ThreadTaskRunnerHandles) 85 // No SequencedTaskRunnerHandle (which includes ThreadTaskRunnerHandles)
40 // should already be set for this thread. 86 // should already be set for this thread.
41 DCHECK(!SequencedTaskRunnerHandle::IsSet()); 87 DCHECK(!SequencedTaskRunnerHandle::IsSet());
42 lazy_tls_ptr.Pointer()->Set(this); 88 lazy_tls_ptr.Pointer()->Set(this);
43 } 89 }
44 90
45 ThreadTaskRunnerHandle::~ThreadTaskRunnerHandle() { 91 ThreadTaskRunnerHandle::~ThreadTaskRunnerHandle() {
46 DCHECK(task_runner_->BelongsToCurrentThread()); 92 DCHECK(task_runner_->BelongsToCurrentThread());
47 DCHECK_EQ(lazy_tls_ptr.Pointer()->Get(), this); 93 DCHECK_EQ(lazy_tls_ptr.Pointer()->Get(), this);
48 lazy_tls_ptr.Pointer()->Set(nullptr); 94 lazy_tls_ptr.Pointer()->Set(nullptr);
49 } 95 }
50 96
51 } // namespace base 97 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698