Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 26570007: Add minidump_stackwalk and chrome to chromium_gpu*_builder targets (Closed)

Created:
7 years, 2 months ago by Zhenyao Mo
Modified:
7 years, 2 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add minidump_stackwalk and chrome to chromium_gpu*_builder targets Also, get rid of the depreciated gpu_tests target. BUG=308190 TEST=main waterfall, gpu waterfall R=kbr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229228

Patch Set 1 #

Total comments: 2

Patch Set 2 : update #

Patch Set 3 : rebase #

Patch Set 4 : add chrome dependency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -18 lines) Patch
M build/all.gyp View 1 2 3 3 chunks +22 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Zhenyao Mo
Ken, please take a look.
7 years, 2 months ago (2013-10-16 21:01:03 UTC) #1
Ken Russell (switch to Gerrit)
LGTM if it passes the try jobs. https://codereview.chromium.org/26570007/diff/1/build/all.gyp File build/all.gyp (right): https://codereview.chromium.org/26570007/diff/1/build/all.gyp#newcode410 build/all.gyp:410: ['OS!="ios" and ...
7 years, 2 months ago (2013-10-16 22:52:55 UTC) #2
Zhenyao Mo
https://codereview.chromium.org/26570007/diff/1/build/all.gyp File build/all.gyp (right): https://codereview.chromium.org/26570007/diff/1/build/all.gyp#newcode410 build/all.gyp:410: ['OS!="ios" and OS!="win"', { On 2013/10/16 22:52:55, Ken Russell ...
7 years, 2 months ago (2013-10-16 22:58:55 UTC) #3
Ken Russell (switch to Gerrit)
OK, thanks. LGTM again then.
7 years, 2 months ago (2013-10-16 23:07:11 UTC) #4
Zhenyao Mo
Ken: please take another look. I explicitly add a dependency to chrome, as win_gpu bot ...
7 years, 2 months ago (2013-10-17 20:01:13 UTC) #5
Ken Russell (switch to Gerrit)
Thanks, looks great. LGTM
7 years, 2 months ago (2013-10-17 20:40:31 UTC) #6
Ken Russell (switch to Gerrit)
Please also add the chrome dependency to the CL description.
7 years, 2 months ago (2013-10-17 20:41:27 UTC) #7
Zhenyao Mo
7 years, 2 months ago (2013-10-17 21:12:17 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 manually as r229228 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698