Removed NULL checks for operator new() return value.

Removed NULL checks for operator new() return value.

BUG=271530
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227702

[Nico, 2013-10-08 23:24:32]

lgtm

Thanks!


On Tue, Oct 8, 2013 at 4:22 PM, <vitalybuka@chromium.org> wrote:

> Reviewers: Nico,
>
> Description:
> Removed NULL checks for operator new() return value.
>
> BUG=271530
>
> Please review this at
https://codereview.chromium.**org/26570005/<https://codereview.chromium.org/2...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files (+11, -26 lines):
>   M cloud_print/virtual_driver/**win/port_monitor/port_monitor.**cc
>
>
> Index: cloud_print/virtual_driver/**win/port_monitor/port_monitor.**cc
> diff --git a/cloud_print/virtual_driver/**win/port_monitor/port_monitor.**cc
> b/cloud_print/virtual_driver/**win/port_monitor/port_monitor.**cc
> index ce146c713562e1bc48d3188ca8559c**f09f27a304..**
> d20b5851f29d94bc15afe6bab31cfb**dbba072361 100644
> --- a/cloud_print/virtual_driver/**win/port_monitor/port_monitor.**cc
> +++ b/cloud_print/virtual_driver/**win/port_monitor/port_monitor.**cc
> @@ -384,18 +384,12 @@ BOOL WINAPI Monitor2EnumPorts(HANDLE,
>  }
>
>  BOOL WINAPI Monitor2OpenPort(HANDLE, wchar_t*, HANDLE* handle) {
> -  PortData* port_data = new PortData();
> -  if (port_data == NULL) {
> -    LOG(ERROR) << "Unable to allocate memory for internal structures.";
> -    SetLastError(E_OUTOFMEMORY);
> -    return FALSE;
> -  }
>    if (handle == NULL) {
>      LOG(ERROR) << "handle should not be NULL.";
>      SetLastError(ERROR_INVALID_**PARAMETER);
>      return FALSE;
>    }
> -  *handle = (HANDLE)port_data;
> +  *handle = new PortData();
>    return TRUE;
>  }
>
> @@ -549,13 +543,8 @@ BOOL WINAPI Monitor2XcvOpenPort(HANDLE,
>      return FALSE;
>    }
>    XcvUiData* xcv_data = new XcvUiData();
> -  if (xcv_data == NULL) {
> -    LOG(ERROR) << "Unable to allocate memory for internal structures.";
> -    SetLastError(E_OUTOFMEMORY);
> -    return FALSE;
> -  }
>    xcv_data->granted_access = granted_access;
> -  *handle = (HANDLE)xcv_data;
> +  *handle = xcv_data;
>    return TRUE;
>  }
>
> @@ -621,22 +610,18 @@ BOOL WINAPI MonitorUiConfigureOrDeletePort**UI(const
> wchar_t*,
>
>  MONITOR2* WINAPI InitializePrintMonitor2(**MONITORINIT*,
>                                           HANDLE* handle) {
> -  cloud_print::MonitorData* monitor_data = new cloud_print::MonitorData;
> -  if (monitor_data == NULL) {
> -    return NULL;
> -  }
> -  if (handle != NULL) {
> -    *handle = (HANDLE)monitor_data;
> -    if (!cloud_print::kIsUnittest) {
> -      // Unit tests set up their own AtExitManager
> -      monitor_data->at_exit_manager.**reset(new base::AtExitManager());
> -      // Single spooler.exe handles verbose users.
> -      PathService::DisableCache();
> -    }
> -  } else {
> +  if (handle == NULL) {
>      SetLastError(ERROR_INVALID_**PARAMETER);
>      return NULL;
>    }
> +  cloud_print::MonitorData* monitor_data = new cloud_print::MonitorData;
> +  *handle = monitor_data;
> +  if (!cloud_print::kIsUnittest) {
> +    // Unit tests set up their own AtExitManager
> +    monitor_data->at_exit_manager.**reset(new base::AtExitManager());
> +    // Single spooler.exe handles verbose users.
> +    PathService::DisableCache();
> +  }
>    return &cloud_print::g_monitor_2;
>  }
>
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-10-08 23:25:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/26570005/1

[commit-bot: I haz the power, 2013-10-09 02:37:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/26570005/1

[commit-bot: I haz the power, 2013-10-09 02:51:49]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_db...

[commit-bot: I haz the power, 2013-10-09 05:07:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/26570005/1

[commit-bot: I haz the power, 2013-10-09 08:24:47]

Change committed as 227702