Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Side by Side Diff: components/ssl_config/ssl_config_service_manager_pref.cc

Issue 2656953002: Revert of Remove remnants of DHE support. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/ssl_config/ssl_config_prefs.cc ('k') | net/socket/ssl_client_socket_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 #include "components/ssl_config/ssl_config_service_manager.h" 4 #include "components/ssl_config/ssl_config_service_manager.h"
5 5
6 #include <stdint.h> 6 #include <stdint.h>
7 7
8 #include <algorithm> 8 #include <algorithm>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
168 void OnDisabledCipherSuitesChange(PrefService* local_state); 168 void OnDisabledCipherSuitesChange(PrefService* local_state);
169 169
170 PrefChangeRegistrar local_state_change_registrar_; 170 PrefChangeRegistrar local_state_change_registrar_;
171 171
172 // The local_state prefs (should only be accessed from UI thread) 172 // The local_state prefs (should only be accessed from UI thread)
173 BooleanPrefMember rev_checking_enabled_; 173 BooleanPrefMember rev_checking_enabled_;
174 BooleanPrefMember rev_checking_required_local_anchors_; 174 BooleanPrefMember rev_checking_required_local_anchors_;
175 BooleanPrefMember sha1_local_anchors_enabled_; 175 BooleanPrefMember sha1_local_anchors_enabled_;
176 StringPrefMember ssl_version_min_; 176 StringPrefMember ssl_version_min_;
177 StringPrefMember ssl_version_max_; 177 StringPrefMember ssl_version_max_;
178 BooleanPrefMember dhe_enabled_;
178 179
179 // The cached list of disabled SSL cipher suites. 180 // The cached list of disabled SSL cipher suites.
180 std::vector<uint16_t> disabled_cipher_suites_; 181 std::vector<uint16_t> disabled_cipher_suites_;
181 182
182 scoped_refptr<SSLConfigServicePref> ssl_config_service_; 183 scoped_refptr<SSLConfigServicePref> ssl_config_service_;
183 184
184 scoped_refptr<base::SingleThreadTaskRunner> io_task_runner_; 185 scoped_refptr<base::SingleThreadTaskRunner> io_task_runner_;
185 186
186 DISALLOW_COPY_AND_ASSIGN(SSLConfigServiceManagerPref); 187 DISALLOW_COPY_AND_ASSIGN(SSLConfigServiceManagerPref);
187 }; 188 };
(...skipping 20 matching lines...) Expand all
208 rev_checking_required_local_anchors_.Init( 209 rev_checking_required_local_anchors_.Init(
209 ssl_config::prefs::kCertRevocationCheckingRequiredLocalAnchors, 210 ssl_config::prefs::kCertRevocationCheckingRequiredLocalAnchors,
210 local_state, local_state_callback); 211 local_state, local_state_callback);
211 sha1_local_anchors_enabled_.Init( 212 sha1_local_anchors_enabled_.Init(
212 ssl_config::prefs::kCertEnableSha1LocalAnchors, local_state, 213 ssl_config::prefs::kCertEnableSha1LocalAnchors, local_state,
213 local_state_callback); 214 local_state_callback);
214 ssl_version_min_.Init(ssl_config::prefs::kSSLVersionMin, local_state, 215 ssl_version_min_.Init(ssl_config::prefs::kSSLVersionMin, local_state,
215 local_state_callback); 216 local_state_callback);
216 ssl_version_max_.Init(ssl_config::prefs::kSSLVersionMax, local_state, 217 ssl_version_max_.Init(ssl_config::prefs::kSSLVersionMax, local_state,
217 local_state_callback); 218 local_state_callback);
219 dhe_enabled_.Init(ssl_config::prefs::kDHEEnabled, local_state,
220 local_state_callback);
218 221
219 local_state_change_registrar_.Init(local_state); 222 local_state_change_registrar_.Init(local_state);
220 local_state_change_registrar_.Add(ssl_config::prefs::kCipherSuiteBlacklist, 223 local_state_change_registrar_.Add(ssl_config::prefs::kCipherSuiteBlacklist,
221 local_state_callback); 224 local_state_callback);
222 225
223 OnDisabledCipherSuitesChange(local_state); 226 OnDisabledCipherSuitesChange(local_state);
224 227
225 // Initialize from UI thread. This is okay as there shouldn't be anything on 228 // Initialize from UI thread. This is okay as there shouldn't be anything on
226 // the IO thread trying to access it yet. 229 // the IO thread trying to access it yet.
227 GetSSLConfigFromPrefs(&ssl_config_service_->cached_config_); 230 GetSSLConfigFromPrefs(&ssl_config_service_->cached_config_);
228 } 231 }
229 232
230 // static 233 // static
231 void SSLConfigServiceManagerPref::RegisterPrefs(PrefRegistrySimple* registry) { 234 void SSLConfigServiceManagerPref::RegisterPrefs(PrefRegistrySimple* registry) {
232 net::SSLConfig default_config; 235 net::SSLConfig default_config;
233 registry->RegisterBooleanPref( 236 registry->RegisterBooleanPref(
234 ssl_config::prefs::kCertRevocationCheckingEnabled, 237 ssl_config::prefs::kCertRevocationCheckingEnabled,
235 default_config.rev_checking_enabled); 238 default_config.rev_checking_enabled);
236 registry->RegisterBooleanPref( 239 registry->RegisterBooleanPref(
237 ssl_config::prefs::kCertRevocationCheckingRequiredLocalAnchors, 240 ssl_config::prefs::kCertRevocationCheckingRequiredLocalAnchors,
238 default_config.rev_checking_required_local_anchors); 241 default_config.rev_checking_required_local_anchors);
239 registry->RegisterBooleanPref(ssl_config::prefs::kCertEnableSha1LocalAnchors, 242 registry->RegisterBooleanPref(ssl_config::prefs::kCertEnableSha1LocalAnchors,
240 false); 243 false);
241 registry->RegisterStringPref(ssl_config::prefs::kSSLVersionMin, 244 registry->RegisterStringPref(ssl_config::prefs::kSSLVersionMin,
242 std::string()); 245 std::string());
243 registry->RegisterStringPref(ssl_config::prefs::kSSLVersionMax, 246 registry->RegisterStringPref(ssl_config::prefs::kSSLVersionMax,
244 std::string()); 247 std::string());
245 registry->RegisterListPref(ssl_config::prefs::kCipherSuiteBlacklist); 248 registry->RegisterListPref(ssl_config::prefs::kCipherSuiteBlacklist);
249 registry->RegisterBooleanPref(ssl_config::prefs::kDHEEnabled,
250 default_config.dhe_enabled);
246 } 251 }
247 252
248 net::SSLConfigService* SSLConfigServiceManagerPref::Get() { 253 net::SSLConfigService* SSLConfigServiceManagerPref::Get() {
249 return ssl_config_service_.get(); 254 return ssl_config_service_.get();
250 } 255 }
251 256
252 void SSLConfigServiceManagerPref::OnPreferenceChanged( 257 void SSLConfigServiceManagerPref::OnPreferenceChanged(
253 PrefService* prefs, 258 PrefService* prefs,
254 const std::string& pref_name_in) { 259 const std::string& pref_name_in) {
255 DCHECK(prefs); 260 DCHECK(prefs);
(...skipping 27 matching lines...) Expand all
283 config->version_max = net::kDefaultSSLVersionMax; 288 config->version_max = net::kDefaultSSLVersionMax;
284 uint16_t version_min = SSLProtocolVersionFromString(version_min_str); 289 uint16_t version_min = SSLProtocolVersionFromString(version_min_str);
285 uint16_t version_max = SSLProtocolVersionFromString(version_max_str); 290 uint16_t version_max = SSLProtocolVersionFromString(version_max_str);
286 if (version_min) { 291 if (version_min) {
287 config->version_min = version_min; 292 config->version_min = version_min;
288 } 293 }
289 if (version_max) { 294 if (version_max) {
290 config->version_max = version_max; 295 config->version_max = version_max;
291 } 296 }
292 config->disabled_cipher_suites = disabled_cipher_suites_; 297 config->disabled_cipher_suites = disabled_cipher_suites_;
298 config->dhe_enabled = dhe_enabled_.GetValue();
293 } 299 }
294 300
295 void SSLConfigServiceManagerPref::OnDisabledCipherSuitesChange( 301 void SSLConfigServiceManagerPref::OnDisabledCipherSuitesChange(
296 PrefService* local_state) { 302 PrefService* local_state) {
297 const base::ListValue* value = 303 const base::ListValue* value =
298 local_state->GetList(ssl_config::prefs::kCipherSuiteBlacklist); 304 local_state->GetList(ssl_config::prefs::kCipherSuiteBlacklist);
299 disabled_cipher_suites_ = ParseCipherSuites(ListValueToStringVector(value)); 305 disabled_cipher_suites_ = ParseCipherSuites(ListValueToStringVector(value));
300 } 306 }
301 307
302 //////////////////////////////////////////////////////////////////////////////// 308 ////////////////////////////////////////////////////////////////////////////////
303 // SSLConfigServiceManager 309 // SSLConfigServiceManager
304 310
305 namespace ssl_config { 311 namespace ssl_config {
306 // static 312 // static
307 SSLConfigServiceManager* SSLConfigServiceManager::CreateDefaultManager( 313 SSLConfigServiceManager* SSLConfigServiceManager::CreateDefaultManager(
308 PrefService* local_state, 314 PrefService* local_state,
309 const scoped_refptr<base::SingleThreadTaskRunner>& io_task_runner) { 315 const scoped_refptr<base::SingleThreadTaskRunner>& io_task_runner) {
310 return new SSLConfigServiceManagerPref(local_state, io_task_runner); 316 return new SSLConfigServiceManagerPref(local_state, io_task_runner);
311 } 317 }
312 318
313 // static 319 // static
314 void SSLConfigServiceManager::RegisterPrefs(PrefRegistrySimple* registry) { 320 void SSLConfigServiceManager::RegisterPrefs(PrefRegistrySimple* registry) {
315 SSLConfigServiceManagerPref::RegisterPrefs(registry); 321 SSLConfigServiceManagerPref::RegisterPrefs(registry);
316 } 322 }
317 } // namespace ssl_config 323 } // namespace ssl_config
OLDNEW
« no previous file with comments | « components/ssl_config/ssl_config_prefs.cc ('k') | net/socket/ssl_client_socket_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698