Makes permission bubble properly handle browser-type keyboard events.

Makes permission bubble properly handle browser-type keyboard events.

Specifically, subclasses InfoBubbleWindow with the sole purpose of catching
calls to -performKeyEquivalent: and forward them to the parent window.

Longer explanation:
The base implementation of -performKeyEquivalent:, found in
ChromeEventProcessingWindow, attempts to hand browser key events off to 
the window’s responder or delegate.  The InfoBubbleWindow's responder and 
delegate do not implement the correct protocols to handle the events, and so 
the events are not completed.

This subclasses -performKeyEquivalent: to send the events to the parent 
window, which, if it is a browser window, will have the correct responder and 
thus handle the events.

BUG=367206
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267996

[groby-ooo-7-16, 2014-05-02 01:43:25]

https://codereview.chromium.org/265693009/diff/1/chrome/browser/ui/cocoa/webs...
File chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm
(right):

https://codereview.chromium.org/265693009/diff/1/chrome/browser/ui/cocoa/webs...
chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm:132: //
permission bubble to its parent window, which is a browser window.
If the parent window is a browser window, I believe what you want is 

NativeWebKeyboardEvent wrappedEvent(event)
if ([BrowserWindowUtils shouldHandleKeyboardEvent:wrappedEvent])
    [BrowserWindowUtils handleKeyboardEvent:event inWindow:[self parentWindow]];

This allows you to handle menu shortcuts, as well.

[leng, 2014-05-02 16:24:58]

https://codereview.chromium.org/265693009/diff/1/chrome/browser/ui/cocoa/webs...
File chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm
(right):

https://codereview.chromium.org/265693009/diff/1/chrome/browser/ui/cocoa/webs...
chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm:132: //
permission bubble to its parent window, which is a browser window.
On 2014/05/02 01:43:25, groby wrote:
> If the parent window is a browser window, I believe what you want is 
> 
> NativeWebKeyboardEvent wrappedEvent(event)
> if ([BrowserWindowUtils shouldHandleKeyboardEvent:wrappedEvent])
>     [BrowserWindowUtils handleKeyboardEvent:event inWindow:[self
parentWindow]];
> 
> This allows you to handle menu shortcuts, as well.

Thanks, done.

[groby-ooo-7-16, 2014-05-02 22:14:39]

lgtm

[leng, 2014-05-02 22:21:37]

The CQ bit was checked by leng@chromium.org

[commit-bot: I haz the power, 2014-05-02 22:22:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/leng@chromium.org/265693009/20001

[commit-bot: I haz the power, 2014-05-03 01:06:08]

Change committed as 267996