Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 265693005: Add a fix for a spurious assert in SkMatrixConvolutionImageFilter. (Closed)

Created:
6 years, 7 months ago by Stephen White
Modified:
6 years, 7 months ago
Reviewers:
sugoi1, sugoi
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add a fix for a spurious assert in SkMatrixConvolutionImageFilter. When matrix convolution processes border pixels with zero width, it asserts in getAddr32() with an invalid x coordinate. The assert is harmless, since the returned pointer is never accessed (the next line is a loop from left to right, which does nothing, since left == right). However, the fix is simple: early out on an empty rect before entering the outer loop. R=sugoi@chromium.org Committed: https://code.google.com/p/skia/source/detail?r=14497

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M src/effects/SkMatrixConvolutionImageFilter.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Stephen White
sugoi@: PTAL. Thanks!
6 years, 7 months ago (2014-05-01 01:52:45 UTC) #1
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 7 months ago (2014-05-01 02:15:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/senorblanco@chromium.org/265693005/1
6 years, 7 months ago (2014-05-01 02:15:16 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 02:15:17 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-01 02:15:17 UTC) #5
sugoi
On 2014/05/01 02:15:17, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
6 years, 7 months ago (2014-05-01 12:20:06 UTC) #6
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 7 months ago (2014-05-01 12:45:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/senorblanco@chromium.org/265693005/1
6 years, 7 months ago (2014-05-01 12:45:31 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-01 12:45:32 UTC) #9
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-01 12:45:33 UTC) #10
Stephen White
6 years, 7 months ago (2014-05-01 14:03:44 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 manually as r14497 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698