Chromium Code Reviews

Unified Diff: content/browser/devtools/protocol/input_handler.cc

Issue 2656903005: ChromeDriver: Handle key events properly on Mac (Closed)
Patch Set: changes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: content/browser/devtools/protocol/input_handler.cc
diff --git a/content/browser/devtools/protocol/input_handler.cc b/content/browser/devtools/protocol/input_handler.cc
index 072456c764236fd6216cceb255e984cb8d6b68f7..c1f20d21d814b26fac66663df29dd610ca4bc5c3 100644
--- a/content/browser/devtools/protocol/input_handler.cc
+++ b/content/browser/devtools/protocol/input_handler.cc
@@ -12,6 +12,7 @@
#include "base/trace_event/trace_event.h"
#include "cc/output/compositor_frame_metadata.h"
#include "content/browser/devtools/devtools_session.h"
+#include "content/browser/devtools/protocol/native_input_event_builder.h"
#include "content/browser/frame_host/render_frame_host_impl.h"
#include "content/browser/renderer_host/render_widget_host_impl.h"
#include "content/common/input/synthetic_pinch_gesture_params.h"
@@ -286,7 +287,7 @@ void InputHandler::DispatchKeyEvent(
auto_repeat.fromMaybe(false),
is_keypad.fromMaybe(false)),
GetEventTimeTicks(std::move(timestamp)));
- event.skip_in_browser = true;
+
if (!SetKeyboardEventText(event.text, std::move(text))) {
callback->sendFailure(Response::InvalidParams("Invalid 'text' parameter"));
return;
@@ -318,7 +319,7 @@ void InputHandler::DispatchKeyEvent(
callback->sendFailure(Response::InternalError());
return;
}
-
+ event.os_event = NativeInputEventBuilder::CreateEvent(event);
host_->GetRenderWidgetHost()->Focus();
input_queued_ = false;
pending_key_callbacks_.push_back(std::move(callback));

Powered by Google App Engine