ChromeDriver: Handle key events properly on Mac

content/browser/devtools/protocol/native_input_event_builder_mac.mm

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/strings/sys_string_conversions.h"
+#include "content/browser/devtools/protocol/native_input_event_builder.h"
+#include "third_party/WebKit/public/platform/WebInputEvent.h"
+#include <Cocoa/Cocoa.h>
+
+namespace content {
+namespace protocol {
+
+// Mac requires a native event to emulate key events. This method gives
+// only crude capabilities (see: crbug.com/667387).
+gfx::NativeEvent NativeInputEventBuilder::Build(
+      const NativeWebKeyboardEvent& event) {
+  NSEventType type = NSKeyUp;
+  if (event.type() == blink::WebInputEvent::RawKeyDown ||
+      event.type() == blink::WebInputEvent::KeyDown)
+    type = NSKeyUp;

[pfeldman, 2017/02/10 22:59:08]

NSKeyDown

[allada, 2017/02/14 02:48:06]

Done.

+  NSString* character = base::SysUTF16ToNSString(base::string16(&event.text[0],
+      NativeWebKeyboardEvent::textLengthCap));

[pfeldman, 2017/02/10 22:59:08]

This will force it to be NativeWebKeyboardEvent::textLengthCap even though it
was 0-terminated.

[allada, 2017/02/14 02:48:06]

Done.

+  int modifiers = event.modifiers();
+  NSUInteger flags =
+      (modifiers & blink::WebInputEvent::ShiftKey ? NSShiftKeyMask : 0) |
+      (modifiers & blink::WebInputEvent::ControlKey ? NSControlKeyMask : 0) |
+      (modifiers & blink::WebInputEvent::AltKey ? NSAlternateKeyMask : 0) |
+      (modifiers & blink::WebInputEvent::MetaKey ? NSCommandKeyMask : 0);
+
+  return [[NSEvent keyEventWithType:type
+                           location:NSZeroPoint
+                      modifierFlags:flags
+                          timestamp:0

[pfeldman, 2017/02/10 22:59:08]

There is still no timestamp.

[allada, 2017/02/14 02:48:06]

no change per our offline talk.

+                       windowNumber:0
+                            context:nil
+                         characters:character
+        charactersIgnoringModifiers:character
+                          isARepeat:NO
+                            keyCode:event.nativeKeyCode] retain];
+};
+
+}  // namespace protocol
+}  // namespace content