Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Side by Side Diff: content/browser/devtools/protocol/native_input_event_builder.h

Issue 2656903005: ChromeDriver: Handle key events properly on Mac (Closed)
Patch Set: changes Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CONTENT_BROWSER_DEVTOOLS_PROTOCOL_NATIVE_INPUT_EVENT_BUILDER_H_
6 #define CONTENT_BROWSER_DEVTOOLS_PROTOCOL_NATIVE_INPUT_EVENT_BUILDER_H_
7
8 #include "content/public/browser/native_web_keyboard_event.h"
9
10 namespace content {
11 namespace protocol {
12
13 class NativeInputEventBuilder {
14 public:
15 #if defined(OS_MACOSX)
16 static gfx::NativeEvent Build(const NativeWebKeyboardEvent& event);
pfeldman 2017/02/10 22:59:07 These are the same, ifdef in mm instead.
allada 2017/02/14 02:48:06 Per our offline talk, the optimizer should optimiz
17 #else
18 // We only need this for Macs because they require an OS event to process
19 // some keyboard events in browser (see: crbug.com/667387).
20 static gfx::NativeEvent Build(const NativeWebKeyboardEvent& event) {
21 return nullptr;
22 }
23 #endif
24 };
25
26 } // namespace protocol
27 } // namespace content
28
29 #endif // CONTENT_BROWSER_DEVTOOLS_PROTOCOL_NATIVE_INPUT_EVENT_BUILDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698