Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2285)

Unified Diff: ui/compositor/test/in_process_context_factory.cc

Issue 2656893003: Let DelegateFrameHost in Mac and Android use correct FrameSinkId during creation (Closed)
Patch Set: more comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/compositor/test/in_process_context_factory.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/compositor/test/in_process_context_factory.cc
diff --git a/ui/compositor/test/in_process_context_factory.cc b/ui/compositor/test/in_process_context_factory.cc
index cdb7b52650325e61c55b671eba5a7a94fd51df58..ff90047aa622a99ce2ecd674ac1d73c185dd9036 100644
--- a/ui/compositor/test/in_process_context_factory.cc
+++ b/ui/compositor/test/in_process_context_factory.cc
@@ -127,7 +127,7 @@ struct InProcessContextFactory::PerCompositorData {
InProcessContextFactory::InProcessContextFactory(
bool context_factory_for_test,
cc::SurfaceManager* surface_manager)
- : next_surface_client_id_(1u),
+ : next_surface_sink_id_(1u),
use_test_surface_(true),
context_factory_for_test_(context_factory_for_test),
surface_manager_(surface_manager) {
@@ -281,7 +281,12 @@ cc::TaskGraphRunner* InProcessContextFactory::GetTaskGraphRunner() {
}
cc::FrameSinkId InProcessContextFactory::AllocateFrameSinkId() {
- return cc::FrameSinkId(next_surface_client_id_++, 0);
+ // The FrameSinkId generated here must be unique with
+ // RenderWidgetHostViewAura's
+ // and RenderWidgetHostViewMac's FrameSinkId allocation.
+ // TODO(crbug.com/685777): Centralize allocation in one place for easier
+ // maintenance.
+ return cc::FrameSinkId(0, next_surface_sink_id_++);
}
cc::SurfaceManager* InProcessContextFactory::GetSurfaceManager() {
« no previous file with comments | « ui/compositor/test/in_process_context_factory.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698