Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1439)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 2656893003: Let DelegateFrameHost in Mac and Android use correct FrameSinkId during creation (Closed)
Patch Set: more comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc
index 5e0d3028d7f540e1da6f549a0eff20597d97d4df..9491607ef928c6237738eaa3ef08902a9557dba0 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -1915,6 +1915,10 @@ void RenderWidgetHostViewAura::CreateDelegatedFrameHostClient() {
// GuestViews have two RenderWidgetHostViews and so we need to make sure
// we don't have FrameSinkId collisions.
+ // The FrameSinkId generated here must be unique with FrameSinkId allocated
+ // in ContextFactoryPrivate.
+ // TODO(crbug.com/685777): Centralize allocation in one place for easier
+ // maintenance.
ImageTransportFactory* factory = ImageTransportFactory::GetInstance();
cc::FrameSinkId frame_sink_id =
is_guest_view_hack_

Powered by Google App Engine
This is Rietveld 408576698