Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Unified Diff: content/browser/compositor/gpu_process_transport_factory.cc

Issue 2656893003: Let DelegateFrameHost in Mac and Android use correct FrameSinkId during creation (Closed)
Patch Set: more comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/browser_compositor_view_mac.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/compositor/gpu_process_transport_factory.cc
diff --git a/content/browser/compositor/gpu_process_transport_factory.cc b/content/browser/compositor/gpu_process_transport_factory.cc
index 8a0995a4c78a0a1f31be7143b6b29fa65c6355cd..0fdb76366bacc0473858a711149e2c3d0c75731a 100644
--- a/content/browser/compositor/gpu_process_transport_factory.cc
+++ b/content/browser/compositor/gpu_process_transport_factory.cc
@@ -690,6 +690,11 @@ GpuProcessTransportFactory::GetContextFactoryPrivate() {
}
cc::FrameSinkId GpuProcessTransportFactory::AllocateFrameSinkId() {
+ // The FrameSinkId generated here must be unique with
+ // RenderWidgetHostViewAura's
+ // and RenderWidgetHostViewMac's FrameSinkId allocation.
+ // TODO(crbug.com/685777): Centralize allocation in one place for easier
+ // maintenance.
return cc::FrameSinkId(0, next_sink_id_++);
}
« no previous file with comments | « no previous file | content/browser/renderer_host/browser_compositor_view_mac.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698