Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: chrome/browser/ui/views/payments/order_summary_view_controller.cc

Issue 2656853002: [Web Payments] Refactor the row display code. (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/browser/ui/views/payments/payment_request_row_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/payments/order_summary_view_controller.cc
diff --git a/chrome/browser/ui/views/payments/order_summary_view_controller.cc b/chrome/browser/ui/views/payments/order_summary_view_controller.cc
index b0f0cc763328c91146722e96c99624444d203e7d..f0f33f9176a1b6152702fc9ef991811b4788c0d0 100644
--- a/chrome/browser/ui/views/payments/order_summary_view_controller.cc
+++ b/chrome/browser/ui/views/payments/order_summary_view_controller.cc
@@ -43,12 +43,17 @@ std::unique_ptr<views::View> CreateLineItemView(const base::string16& label,
DialogViewID amount_label_id) {
std::unique_ptr<views::View> row = base::MakeUnique<views::View>();
- row->SetBorder(views::CreateSolidSidedBorder(0, 0, 1, 0, SK_ColorLTGRAY));
+ row->SetBorder(payments::CreatePaymentRequestRowBorder());
views::GridLayout* layout = new views::GridLayout(row.get());
+ // The vertical spacing for these rows is slightly different than the spacing
+ // spacing for clickable rows, so don't use kPaymentRequestRowVerticalInsets.
constexpr int kRowVerticalInset = 12;
- layout->SetInsets(kRowVerticalInset, 0, kRowVerticalInset, 0);
+ layout->SetInsets(kRowVerticalInset,
+ payments::kPaymentRequestRowHorizontalInsets,
+ kRowVerticalInset,
+ payments::kPaymentRequestRowHorizontalInsets);
row->SetLayoutManager(layout);
views::ColumnSet* columns = layout->AddColumnSet(0);
« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/browser/ui/views/payments/payment_request_row_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698