[Payments] PR: Basic test for the order summary section.

chrome/browser/ui/views/payments/payment_request_interactive_uitest_base.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/payments/payment_request_interactive_uitest_base.h"
 
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/memory/ptr_util.h"
+#include "base/message_loop/message_loop.h"
+#include "base/strings/string16.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
-#include "chrome/browser/ui/views/payments/test_chrome_payment_request_delegate.h"
+#include "chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h"
+#include "chrome/test/base/interactive_test_utils.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/payments/payment_request.h"
 #include "components/payments/payment_request_web_contents_manager.h"
 #include "components/web_modal/web_contents_modal_dialog_manager.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/test/browser_test_utils.h"
+#include "content/public/test/test_utils.h"
 #include "services/service_manager/public/cpp/interface_registry.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "ui/base/test/ui_controls.h"
+#include "ui/views/controls/styled_label.h"
 
 namespace payments {
 
 PaymentRequestInteractiveTestBase::PaymentRequestInteractiveTestBase(
     const std::string& test_file_path)
     : test_file_path_(test_file_path) {}
 PaymentRequestInteractiveTestBase::~PaymentRequestInteractiveTestBase() {}
 
 void PaymentRequestInteractiveTestBase::SetUpCommandLine(
     base::CommandLine* command_line) {
@@ skipping 21 matching lines @@
   registry->AddInterface(base::Bind(
       &PaymentRequestInteractiveTestBase::CreatePaymentRequestForTest,
       base::Unretained(this), web_contents));
 }
 
 void PaymentRequestInteractiveTestBase::OnDialogOpened() {
   if (event_observer_)
     event_observer_->Observe(DialogEvent::DIALOG_OPENED);
 }
 
+void PaymentRequestInteractiveTestBase::OnOrderSummaryOpened() {
+  if (event_observer_)
+    event_observer_->Observe(DialogEvent::ORDER_SUMMARY_OPENED);
+}
+
 void PaymentRequestInteractiveTestBase::OnWidgetDestroyed(
     views::Widget* widget) {
   if (event_observer_)
     event_observer_->Observe(DialogEvent::DIALOG_CLOSED);
 }
 
 void PaymentRequestInteractiveTestBase::InvokePaymentRequestUI() {
   event_observer_.reset(new DialogEventObserver(DialogEvent::DIALOG_OPENED));
 
   content::WebContents* web_contents = GetActiveWebContents();
   const std::string click_buy_button_js =
       "(function() { document.getElementById('buy').click(); })();";
   ASSERT_TRUE(content::ExecuteScript(web_contents, click_buy_button_js));
 
   event_observer_->Wait();
 
   // The web-modal dialog should be open.
   web_modal::WebContentsModalDialogManager* web_contents_modal_dialog_manager =
       web_modal::WebContentsModalDialogManager::FromWebContents(web_contents);
   EXPECT_TRUE(web_contents_modal_dialog_manager->IsDialogActive());
 }
 
+void PaymentRequestInteractiveTestBase::OpenOrderSummaryScreen() {
+  event_observer_.reset(
+      new DialogEventObserver(DialogEvent::ORDER_SUMMARY_OPENED));

[sky, 2017/01/26 23:09:45]

MakeUnique.

[Mathieu, 2017/01/27 00:36:50]

Acknowledged.

+
+  ClickOnDialogView(DialogViewID::PAYMENT_SHEET_SUMMARY_SECTION);
+
+  event_observer_->Wait();
+}
+
 content::WebContents*
 PaymentRequestInteractiveTestBase::GetActiveWebContents() {
   return browser()->tab_strip_model()->GetActiveWebContents();
 }
 
 const std::vector<PaymentRequest*>
 PaymentRequestInteractiveTestBase::GetPaymentRequests(
     content::WebContents* web_contents) {
   PaymentRequestWebContentsManager* manager =
       PaymentRequestWebContentsManager::GetOrCreateForWebContents(web_contents);
   if (!manager)
     return std::vector<PaymentRequest*>();
 
   std::vector<PaymentRequest*> payment_requests_ptrs;
   for (const auto& p : manager->payment_requests_)
     payment_requests_ptrs.push_back(p.first);
   return payment_requests_ptrs;
 }
 
 void PaymentRequestInteractiveTestBase::CreatePaymentRequestForTest(
     content::WebContents* web_contents,
     mojo::InterfaceRequest<payments::mojom::PaymentRequest> request) {
   DCHECK(web_contents);
+  std::unique_ptr<TestChromePaymentRequestDelegate> delegate(
+      new TestChromePaymentRequestDelegate(web_contents, this /* observer */,

[sky, 2017/01/26 23:09:45]

MakeUnique.

[Mathieu, 2017/01/27 00:36:50]

Acknowledged.

+                                           this /* widget_observer */));
+  delegate_ = delegate.get();
   PaymentRequestWebContentsManager::GetOrCreateForWebContents(web_contents)
-      ->CreatePaymentRequest(
-          web_contents,
-          base::MakeUnique<TestChromePaymentRequestDelegate>(
-              web_contents, this /* observer */, this /* widget_observer */),
-          std::move(request));
+      ->CreatePaymentRequest(web_contents, std::move(delegate),
+                             std::move(request));
+}
+
+void PaymentRequestInteractiveTestBase::ClickOnDialogView(
+    DialogViewID view_id) {
+  views::View* view =
+      delegate_->dialog_view()->GetViewByID(static_cast<ViewID>(view_id));

[sky, 2017/01/26 23:09:45]

ViewID->int

[Mathieu, 2017/01/27 00:36:50]

Done.

+  DCHECK(view);
+  ui_test_utils::MoveMouseToCenterAndPress(
+      view, ui_controls::LEFT, ui_controls::DOWN | ui_controls::UP,
+      base::MessageLoop::QuitWhenIdleClosure());
+  content::RunMessageLoop();

[sky, 2017/01/26 23:09:45]

Is there a reason you're not using a RunLoop and supplying the quit closure from
it to the MoveMouseToCenterAndPress?

[Mathieu, 2017/01/27 00:36:50]

That works too! 

+}
+
+const base::string16& PaymentRequestInteractiveTestBase::GetStyledLabelText(
+    DialogViewID view_id) {
+  views::View* view = dialog_view()->GetViewByID(static_cast<ViewID>(view_id));

[sky, 2017/01/26 23:09:45]

ViewID->int

[Mathieu, 2017/01/27 00:36:50]

Done.

+  DCHECK(view);
+  return static_cast<views::StyledLabel*>(view)->text();
 }
 
 PaymentRequestInteractiveTestBase::DialogEventObserver::DialogEventObserver(
     PaymentRequestInteractiveTestBase::DialogEvent event)
     : event_(event), seen_(false) {}
 PaymentRequestInteractiveTestBase::DialogEventObserver::~DialogEventObserver() {
 }
 
 void PaymentRequestInteractiveTestBase::DialogEventObserver::Wait() {
   if (seen_)
@@ skipping 16 matching lines @@
 
 void PaymentRequestInteractiveTestBase::ResetEventObserver(DialogEvent event) {
   event_observer_.reset(new DialogEventObserver(event));
 }
 
 void PaymentRequestInteractiveTestBase::WaitForObservedEvent() {
   event_observer_->Wait();
 }
 
 }  // namespace payments