Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js

Issue 2656823004: DevTools: Move checkbox title element into Shadow DOM (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved. 3 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.
4 * Copyright (C) 2007 Matt Lilek (pewtermoose@gmail.com). 4 * Copyright (C) 2007 Matt Lilek (pewtermoose@gmail.com).
5 * Copyright (C) 2009 Joseph Pecoraro 5 * Copyright (C) 2009 Joseph Pecoraro
6 * 6 *
7 * Redistribution and use in source and binary forms, with or without 7 * Redistribution and use in source and binary forms, with or without
8 * modification, are permitted provided that the following conditions 8 * modification, are permitted provided that the following conditions
9 * are met: 9 * are met:
10 * 10 *
(...skipping 1269 matching lines...) Expand 10 before | Expand all | Expand 10 after
1280 /** 1280 /**
1281 * @param {string=} title 1281 * @param {string=} title
1282 * @param {boolean=} checked 1282 * @param {boolean=} checked
1283 * @param {string=} subtitle 1283 * @param {string=} subtitle
1284 * @return {!Element} 1284 * @return {!Element}
1285 */ 1285 */
1286 UI.createCheckboxLabel = function(title, checked, subtitle) { 1286 UI.createCheckboxLabel = function(title, checked, subtitle) {
1287 var element = createElement('label', 'dt-checkbox'); 1287 var element = createElement('label', 'dt-checkbox');
1288 element.checkboxElement.checked = !!checked; 1288 element.checkboxElement.checked = !!checked;
1289 if (title !== undefined) { 1289 if (title !== undefined) {
1290 element.textElement = element.createChild('div', 'dt-checkbox-text'); 1290 element.textElement = element.shadowRoot.createChild('div', 'dt-checkbox-tex t');
1291 element.textElement.textContent = title; 1291 element.textElement.textContent = title;
1292 if (subtitle !== undefined) { 1292 if (subtitle !== undefined) {
1293 element.subtitleElement = element.textElement.createChild('div', 'dt-check box-subtitle'); 1293 element.subtitleElement = element.textElement.createChild('div', 'dt-check box-subtitle');
1294 element.subtitleElement.textContent = subtitle; 1294 element.subtitleElement.textContent = subtitle;
1295 } 1295 }
1296 } 1296 }
1297 return element; 1297 return element;
1298 }; 1298 };
1299 1299
1300 /** 1300 /**
(...skipping 730 matching lines...) Expand 10 before | Expand all | Expand 10 after
2031 callback(fileSelectorElement.files[0]); 2031 callback(fileSelectorElement.files[0]);
2032 } 2032 }
2033 return fileSelectorElement; 2033 return fileSelectorElement;
2034 }; 2034 };
2035 2035
2036 /** 2036 /**
2037 * @const 2037 * @const
2038 * @type {number} 2038 * @type {number}
2039 */ 2039 */
2040 UI.MaxLengthForDisplayedURLs = 150; 2040 UI.MaxLengthForDisplayedURLs = 150;
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698