DevTools: Move checkbox title element into Shadow DOM

third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 /**
  * @implements {UI.ContextFlavorListener}
  * @implements {SDK.TargetManager.Observer}
  * @implements {UI.ToolbarItem.ItemsProvider}
  * @unrestricted
  */
 Sources.XHRBreakpointsSidebarPane = class extends Components.BreakpointsSidebarPaneBase {
@@ skipping 86 matching lines @@
     var element = createElement('li');
     element._url = url;
     element.addEventListener('contextmenu', this._contextMenu.bind(this, url), true);
 
     var title = url ? Common.UIString('URL contains "%s"', url) : Common.UIString('Any XHR');
     var label = UI.createCheckboxLabel(title, enabled);
     element.appendChild(label);
     label.checkboxElement.addEventListener('click', this._checkboxClicked.bind(this, url), false);
     element._checkboxElement = label.checkboxElement;
 
-    label.textElement.classList.add('cursor-auto');
+    label.classList.add('cursor-auto');

[dgozman, 2017/01/26 23:28:56]

Why change this?

[einbinder, 2017/01/27 00:22:40]

The cursor-auto class is defined in the sources panel css. It doesn't effect the
textElement which is in the shadow dom.

     label.textElement.addEventListener('dblclick', this._labelClicked.bind(this, url), false);
 
     var currentElement = /** @type {?Element} */ (this.listElement.firstChild);
     while (currentElement) {
       if (currentElement._url && currentElement._url < element._url)
         break;
       currentElement = /** @type {?Element} */ (currentElement.nextSibling);
     }
     this.addListElement(element, currentElement);
     this._breakpointElements.set(url, element);
@@ skipping 127 matching lines @@
    */
   _restoreBreakpoints(target) {
     var breakpoints = this._xhrBreakpointsSetting.get();
     for (var i = 0; i < breakpoints.length; ++i) {
       var breakpoint = breakpoints[i];
       if (breakpoint && typeof breakpoint.url === 'string')
         this._setBreakpoint(breakpoint.url, breakpoint.enabled, target);
     }
   }
 };