Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: chrome/browser/devtools/port_forwarding_controller.cc

Issue 26568004: Introduced AndroidDeviceProvider to simplify testing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Made AndroidDevice::HttpQuery virtual for test purposes. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/devtools/port_forwarding_controller.cc
diff --git a/chrome/browser/devtools/port_forwarding_controller.cc b/chrome/browser/devtools/port_forwarding_controller.cc
index f53d6b83e1d4511624b91b0acd8fa4093deb49a5..9513474ca2524bcee971bfb7137bbf5c94813003 100644
--- a/chrome/browser/devtools/port_forwarding_controller.cc
+++ b/chrome/browser/devtools/port_forwarding_controller.cc
@@ -272,9 +272,9 @@ class PortForwardingController::Connection
content::BrowserThread::DeleteOnUIThread> {
public:
Connection(Registry* registry,
- scoped_refptr<DevToolsAdbBridge::AndroidDevice> device,
+ scoped_refptr<AndroidDevice> device,
const std::string& socket,
- scoped_refptr<DevToolsAdbBridge::RefCountedAdbThread> adb_thread,
+ scoped_refptr<RefCountedAdbThread> adb_thread,
PrefService* pref_service);
const PortStatusMap& GetPortStatusMap();
@@ -317,8 +317,8 @@ class PortForwardingController::Connection
virtual bool ProcessIncomingMessage(const std::string& message) OVERRIDE;
PortForwardingController::Registry* registry_;
- scoped_refptr<DevToolsAdbBridge::AndroidDevice> device_;
- scoped_refptr<DevToolsAdbBridge::RefCountedAdbThread> adb_thread_;
+ scoped_refptr<AndroidDevice> device_;
+ scoped_refptr<RefCountedAdbThread> adb_thread_;
PrefChangeRegistrar pref_change_registrar_;
scoped_refptr<AdbWebSocket> web_socket_;
int command_id_;
@@ -332,9 +332,9 @@ class PortForwardingController::Connection
PortForwardingController::Connection::Connection(
Registry* registry,
- scoped_refptr<DevToolsAdbBridge::AndroidDevice> device,
+ scoped_refptr<AndroidDevice> device,
const std::string& socket,
- scoped_refptr<DevToolsAdbBridge::RefCountedAdbThread> adb_thread,
+ scoped_refptr<RefCountedAdbThread> adb_thread,
PrefService* pref_service)
: registry_(registry),
device_(device),
@@ -579,7 +579,7 @@ bool PortForwardingController::Connection::ProcessIncomingMessage(
}
PortForwardingController::PortForwardingController(PrefService* pref_service)
- : adb_thread_(DevToolsAdbBridge::RefCountedAdbThread::GetInstance()),
+ : adb_thread_(RefCountedAdbThread::GetInstance()),
pref_service_(pref_service) {
}

Powered by Google App Engine
This is Rietveld 408576698