chrome/browser/devtools/port_forwarding_controller.h - Issue 26568004: Introduced AndroidDeviceProvider to simplify testing.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/devtools/port_forwarding_controller.h

Issue 26568004: Introduced AndroidDeviceProvider to simplify testing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed all the comments. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/devtools/devtools_device_provider.cc ('K') | « chrome/browser/devtools/devtools_device_provider.cc ('k') | chrome/browser/devtools/port_forwarding_controller.cc » ('j') | chrome/browser/devtools/refcounted_adb_thread.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_DEVTOOLS_PORT_FORWARDING_CONTROLLER_H_	5 #ifndef CHROME_BROWSER_DEVTOOLS_PORT_FORWARDING_CONTROLLER_H_

6 #define CHROME_BROWSER_DEVTOOLS_PORT_FORWARDING_CONTROLLER_H_	6 #define CHROME_BROWSER_DEVTOOLS_PORT_FORWARDING_CONTROLLER_H_

7	7

8 #include <map>	8 #include <map>

9	9

10 #include "chrome/browser/devtools/devtools_adb_bridge.h"	10 #include "chrome/browser/devtools/devtools_adb_bridge.h"

(...skipping 32 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
43 typedef std::map<int, PortStatus> PortStatusMap;	43 typedef std::map<int, PortStatus> PortStatusMap;

44 typedef std::map<std::string, PortStatusMap> DevicesStatus;	44 typedef std::map<std::string, PortStatusMap> DevicesStatus;

45	45

46 DevicesStatus UpdateDeviceList(	46 DevicesStatus UpdateDeviceList(

47 const DevToolsAdbBridge::RemoteDevices& devices);	47 const DevToolsAdbBridge::RemoteDevices& devices);

48	48

49 private:	49 private:

50 class Connection;	50 class Connection;

51 typedef std::map<std::string, Connection* > Registry;	51 typedef std::map<std::string, Connection* > Registry;

52	52

53 scoped_refptr<DevToolsAdbBridge::RefCountedAdbThread> adb_thread_;	53 scoped_refptr<RefCountedAdbThread> adb_thread_;

54 PrefService* pref_service_;	54 PrefService* pref_service_;

55 Registry registry_;	55 Registry registry_;

56	56

57 DISALLOW_COPY_AND_ASSIGN(PortForwardingController);	57 DISALLOW_COPY_AND_ASSIGN(PortForwardingController);

58 };	58 };

59	59

60 #endif // CHROME_BROWSER_DEVTOOLS_PORT_FORWARDING_CONTROLLER_H_	60 #endif // CHROME_BROWSER_DEVTOOLS_PORT_FORWARDING_CONTROLLER_H_

OLD	NEW