Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Unified Diff: chrome/browser/android/offline_pages/background_loader_offliner.h

Issue 2656763002: [Offline pages] Add navigation error handling to background loader. (Closed)
Patch Set: cl comments and format Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/background_loader_offliner.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/background_loader_offliner.h
diff --git a/chrome/browser/android/offline_pages/background_loader_offliner.h b/chrome/browser/android/offline_pages/background_loader_offliner.h
index 0240e148d03c8de83ab838cd1b7b13edd06067de..f9c9002c9112a082a4c785002dafe4f6b4e0aad1 100644
--- a/chrome/browser/android/offline_pages/background_loader_offliner.h
+++ b/chrome/browser/android/offline_pages/background_loader_offliner.h
@@ -43,6 +43,8 @@ class BackgroundLoaderOffliner : public Offliner,
void DidStopLoading() override;
void RenderProcessGone(base::TerminationStatus status) override;
void WebContentsDestroyed() override;
+ void DidFinishNavigation(
+ content::NavigationHandle* navigation_handle) override;
protected:
// Called to reset internal loader and observer state.
@@ -52,6 +54,7 @@ class BackgroundLoaderOffliner : public Offliner,
friend class TestBackgroundLoaderOffliner;
enum SaveState { NONE, SAVING, DELETE_AFTER_SAVE };
+ enum PageLoadState { SUCCESS, RETRIABLE, NONRETRIABLE };
// Called when the page has been saved.
void OnPageSaved(SavePageResult save_result, int64_t offline_id);
@@ -75,6 +78,8 @@ class BackgroundLoaderOffliner : public Offliner,
bool is_low_end_device_;
// Save state.
SaveState save_state_;
+ // Page load state.
+ PageLoadState page_load_state_;
base::WeakPtrFactory<BackgroundLoaderOffliner> weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(BackgroundLoaderOffliner);
« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/background_loader_offliner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698