[Offline pages] Add navigation error handling to background loader.

chrome/browser/android/offline_pages/background_loader_offliner.h

Index: chrome/browser/android/offline_pages/background_loader_offliner.h
diff --git a/chrome/browser/android/offline_pages/background_loader_offliner.h b/chrome/browser/android/offline_pages/background_loader_offliner.h
index 0240e148d03c8de83ab838cd1b7b13edd06067de..228f8050c1224fa73949906331293805322c5397 100644
--- a/chrome/browser/android/offline_pages/background_loader_offliner.h
+++ b/chrome/browser/android/offline_pages/background_loader_offliner.h
@@ -43,6 +43,8 @@ class BackgroundLoaderOffliner : public Offliner,
   void DidStopLoading() override;
   void RenderProcessGone(base::TerminationStatus status) override;
   void WebContentsDestroyed() override;
+  void DidFinishNavigation(
+      content::NavigationHandle* navigation_handle) override;
 
  protected:
   // Called to reset internal loader and observer state.
@@ -75,6 +77,8 @@ class BackgroundLoaderOffliner : public Offliner,
   bool is_low_end_device_;
   // Save state.
   SaveState save_state_;
+  // Error state.
+  bool is_error_;

[Dmitry Titov, 2017/01/25 19:36:55]

naming nit: perhaps it can be more explicit if it was is_error_page_ or
did_navigate_to_error_page_ 

[chili, 2017/01/31 20:07:37]

renamed to page_loading_state_ with enum because that seems better to also
convey whether it's simply loading failed vs no retry

 
   base::WeakPtrFactory<BackgroundLoaderOffliner> weak_ptr_factory_;
   DISALLOW_COPY_AND_ASSIGN(BackgroundLoaderOffliner);