src/ast/scopes.cc - Issue 2656753003: [ast/parsing] Pessimistically assume all top-level variables will be assigned.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast/scopes.cc

Issue 2656753003: [ast/parsing] Pessimistically assume all top-level variables will be assigned. (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ast/scopes.cc

diff --git a/src/ast/scopes.cc b/src/ast/scopes.cc

index 157712b548b574165ba919d4451904c147c3fa4b..f66f3e7b27717254243b3d5345306cf041b72506 100644

--- a/src/ast/scopes.cc

+++ b/src/ast/scopes.cc

@@ -1819,7 +1819,6 @@ void Scope::ResolveTo(ParseInfo* info, VariableProxy* proxy, Variable* var) {

#endif

DCHECK_NOT_NULL(var);

- if (proxy->is_assigned()) var->set_maybe_assigned();

if (AccessNeedsHoleCheck(var, proxy, this)) proxy->set_needs_hole_check();

proxy->BindTo(var);

}

« no previous file with comments | « src/ast/ast.cc ('k') | src/parsing/parser.h » ('j') | src/parsing/parser.h » ('J')