Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2656743002: Remove package:unittest from some tests (Closed)

Created:
3 years, 11 months ago by zra
Modified:
3 years, 11 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove package:unittest from some tests package:unittest is deprecated in favor of package:test. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/dde47b2aad8629c7103905679b2c09762cb3581b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -187 lines) Patch
M tests/language/async_await_test.dart View 1 chunk +1 line, -3 lines 0 comments Download
M tests/language/async_star_pause_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/async_star_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/first_regression_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/future_timeout_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/multiple_timer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/schedule_microtask2_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/lib/async/schedule_microtask3_test.dart View 3 chunks +4 lines, -5 lines 0 comments Download
M tests/lib/async/schedule_microtask5_test.dart View 3 chunks +5 lines, -6 lines 0 comments Download
M tests/lib/async/stream_controller_async_test.dart View 29 chunks +43 lines, -44 lines 0 comments Download
M tests/lib/async/stream_first_where_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/lib/async/stream_from_iterable_test.dart View 8 chunks +13 lines, -14 lines 0 comments Download
M tests/lib/async/stream_iterator_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_join_test.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/lib/async/stream_last_where_test.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M tests/lib/async/stream_periodic2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_periodic3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_periodic4_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_periodic5_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/lib/async/stream_periodic6_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_periodic_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_single_test.dart View 3 chunks +6 lines, -7 lines 0 comments Download
M tests/lib/async/stream_single_to_multi_subscriber_test.dart View 4 chunks +7 lines, -8 lines 0 comments Download
M tests/lib/async/stream_state_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_state_nonzero_timer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_state_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_subscription_as_future_test.dart View 9 chunks +13 lines, -14 lines 0 comments Download
M tests/lib/async/stream_subscription_cancel_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_transform_test.dart View 3 chunks +3 lines, -4 lines 0 comments Download
M tests/lib/async/stream_transformation_broadcast_test.dart View 15 chunks +28 lines, -29 lines 0 comments Download
M tests/lib/async/timer_cancel1_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/timer_cancel2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/timer_cancel_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/timer_isActive_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/timer_repeat_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/timer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/convert/json_lib_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/math/point_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/math/rectangle_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/mirrors/library_uri_io_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/mirrors/library_uri_package_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/sleep_test.dart View 2 chunks +24 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
3 years, 11 months ago (2017-01-25 00:02:56 UTC) #2
Florian Schneider
Lgtm
3 years, 11 months ago (2017-01-25 00:08:49 UTC) #3
zra
3 years, 11 months ago (2017-01-25 16:50:09 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
dde47b2aad8629c7103905679b2c09762cb3581b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698