Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2656703002: Gardening: Updated status file to skip standalone/io/socket_close_test. Test times out on Linux rel… (Closed)

Created:
3 years, 11 months ago by bkonyi
Modified:
3 years, 11 months ago
Reviewers:
zra, Cutch, siva
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Gardening: Updated status file to account for timeout in standalone/io/socket_close_test. Test times out on Linux release IA32. Issue: 28502. BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/f2a097b9c8c3e33c8d84ae220e982eb5fd8700e4

Patch Set 1 #

Total comments: 2

Patch Set 2 : Gardening: Updated status file to skip standalone/io/socket_close_test. Test times out on Linux rel… #

Patch Set 3 : Updated description #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tests/standalone/standalone.status View 1 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
bkonyi
3 years, 11 months ago (2017-01-24 20:55:46 UTC) #2
zra
https://codereview.chromium.org/2656703002/diff/1/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://codereview.chromium.org/2656703002/diff/1/tests/standalone/standalone.status#newcode293 tests/standalone/standalone.status:293: io/socket_close_test: Pass, Timeout # Issue 28502: timeout. It looks ...
3 years, 11 months ago (2017-01-24 21:00:24 UTC) #3
bkonyi
https://codereview.chromium.org/2656703002/diff/1/tests/standalone/standalone.status File tests/standalone/standalone.status (right): https://codereview.chromium.org/2656703002/diff/1/tests/standalone/standalone.status#newcode293 tests/standalone/standalone.status:293: io/socket_close_test: Pass, Timeout # Issue 28502: timeout. On 2017/01/24 ...
3 years, 11 months ago (2017-01-24 21:03:05 UTC) #4
zra
lgtm
3 years, 11 months ago (2017-01-24 23:42:40 UTC) #5
zra
also you might want to update the cl description to remove "to skip" since the ...
3 years, 11 months ago (2017-01-24 23:43:37 UTC) #6
bkonyi
3 years, 11 months ago (2017-01-25 01:21:50 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
f2a097b9c8c3e33c8d84ae220e982eb5fd8700e4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698