Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1106)

Issue 2656693002: Fix MobileStartup.ToolbarInflationTime to use suffixes. (Closed)

Created:
3 years, 11 months ago by Maria
Modified:
3 years, 10 months ago
Reviewers:
rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix MobileStartup.ToolbarInflationTime to use suffixes. This metric doesn't correctly show up on UMA dashboard because the metric used to be recorded internally and without the suffixes. Review-Url: https://codereview.chromium.org/2656693002 Cr-Commit-Position: refs/heads/master@{#446610} Committed: https://chromium.googlesource.com/chromium/src/+/17222332d2a1bf6626921c45e7a0386e53a02734

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Maria
3 years, 11 months ago (2017-01-24 20:02:52 UTC) #2
rkaplow
lgtm
3 years, 11 months ago (2017-01-24 23:10:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656693002/1
3 years, 11 months ago (2017-01-24 23:20:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/270466)
3 years, 11 months ago (2017-01-25 03:24:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656693002/1
3 years, 10 months ago (2017-01-26 04:28:40 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/220720)
3 years, 10 months ago (2017-01-26 06:37:13 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656693002/1
3 years, 10 months ago (2017-01-27 04:52:12 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 06:26:26 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/17222332d2a1bf6626921c45e7a0...

Powered by Google App Engine
This is Rietveld 408576698