Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2656673002: Fix FunctionTypeAliasElementImpl.visitChildren() for type parameters. (Closed)

Created:
3 years, 11 months ago by scheglov
Modified:
3 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix FunctionTypeAliasElementImpl.visitChildren() for type parameters. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/a440bb2a6d4f4452bdd4ce3c782ae3faab1ec665

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M pkg/analyzer/lib/src/dart/element/element.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_driver_test.dart View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 11 months ago (2017-01-24 19:12:19 UTC) #1
Brian Wilkerson
lgtm
3 years, 11 months ago (2017-01-24 19:16:08 UTC) #2
scheglov
3 years, 11 months ago (2017-01-24 19:26:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a440bb2a6d4f4452bdd4ce3c782ae3faab1ec665 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698