third_party/WebKit/Source/core/html/canvas/CanvasContextCreationAttributes.idl - Issue 2656623002: Add rec-2020 and p3 color spaces to canvas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/canvas/CanvasContextCreationAttributes.idl

Issue 2656623002: Add rec-2020 and p3 color spaces to canvas (Closed)

Patch Set: Minor corrections Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/virtual/color_space/fast/canvas/color-space/canvas-colorSpace-attribute.html ('k') | third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h » ('j') | third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/canvas/CanvasContextCreationAttributes.idl

diff --git a/third_party/WebKit/Source/core/html/canvas/CanvasContextCreationAttributes.idl b/third_party/WebKit/Source/core/html/canvas/CanvasContextCreationAttributes.idl

index ff24c90ab2c05478cb9eabbf3ff8a8934cd9b414..d611e60b3f247512fc89eff78dc4e582e9c50b0d 100644

--- a/third_party/WebKit/Source/core/html/canvas/CanvasContextCreationAttributes.idl

+++ b/third_party/WebKit/Source/core/html/canvas/CanvasContextCreationAttributes.idl

@@ -21,11 +21,14 @@

// N.B.: Web IDL doesn't support multiple inheritance of dictionaries.

+enum CanvasColorSpace { "legacy-srgb", "srgb", "linear-rgb", "linear-rec-2020", "linear-p3"};

Justin Novosad 2017/01/26 19:12:42 We should match the strings used by the color-gamu

zakerinasab1 2017/01/26 20:42:34 Done.

[PermissiveDictionaryConversion]

dictionary CanvasContextCreationAttributes {

// Canvas 2D attributes

boolean alpha = true; // Also used for WebGL.

- [RuntimeEnabled=ExperimentalCanvasFeatures] DOMString colorSpace = "legacy-srgb";

+ [RuntimeEnabled=ExperimentalCanvasFeatures] CanvasColorSpace colorSpace = "legacy-srgb";

// WebGL attributes

boolean depth = true;