Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2656613003: Store end_callback and callback_data into local variables before dropping the monitor (Closed)

Created:
3 years, 11 months ago by Cutch
Modified:
3 years, 11 months ago
Reviewers:
rmacnak, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Store end_callback and callback_data into local variables before dropping the monitor BUG= Committed: https://github.com/dart-lang/sdk/commit/bf914d90ad9cbb1e97f715be77665404d8c65a3c

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M runtime/vm/message_handler.cc View 3 chunks +6 lines, -1 line 1 comment Download

Messages

Total messages: 8 (4 generated)
Cutch
3 years, 11 months ago (2017-01-24 16:01:32 UTC) #3
Cutch
Committed patchset #1 (id:1) manually as bf914d90ad9cbb1e97f715be77665404d8c65a3c (presubmit successful).
3 years, 11 months ago (2017-01-24 16:59:41 UTC) #5
rmacnak
lgtm
3 years, 11 months ago (2017-01-24 17:35:10 UTC) #7
siva
3 years, 11 months ago (2017-01-24 19:24:26 UTC) #8
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/2656613003/diff/1/runtime/vm/message_handler.cc
File runtime/vm/message_handler.cc (right):

https://codereview.chromium.org/2656613003/diff/1/runtime/vm/message_handler....
runtime/vm/message_handler.cc:438: if (run_end_callback) {
is run_end_callback still needed, it could just be replaced everywhere
with (end_callback != NULL)

Powered by Google App Engine
This is Rietveld 408576698