Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2656583003: Add inference test functionality based on code point id. (Closed)

Created:
3 years, 11 months ago by Johnni Winther
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add inference test functionality based on code point id. The code point id is meant to be basis for AST/Kernel-IR equivalence and the test framework should thereby be portable to a Kernel based inference. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/c885d809b6d65cbc1bd15289f5d1fc68f0acb090

Patch Set 1 #

Total comments: 20

Patch Set 2 : Updated cf. comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+307 lines, -49 lines) Patch
M pkg/compiler/lib/src/inferrer/builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/types/types.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A tests/compiler/dart2js/annotated_code_helper.dart View 1 1 chunk +100 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/inference/enumerator.dart View 1 1 chunk +52 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/inference/inference_test_helper.dart View 1 1 chunk +106 lines, -0 lines 0 comments Download
A tests/compiler/dart2js/inference/send_test.dart View 1 chunk +31 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/sourcemaps/stacktrace_test.dart View 1 2 chunks +15 lines, -46 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Johnni Winther
https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/inference/send_test.dart File tests/compiler/dart2js/inference/send_test.dart (right): https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/inference/send_test.dart#newcode16 tests/compiler/dart2js/inference/send_test.dart:16: return a.@{[exact=Sub]}method; This test would have caught error in ...
3 years, 11 months ago (2017-01-24 12:07:41 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/annotated_code_helper.dart File tests/compiler/dart2js/annotated_code_helper.dart (right): https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/annotated_code_helper.dart#newcode16 tests/compiler/dart2js/annotated_code_helper.dart:16: /// 0-based character offset with with => of ...
3 years, 11 months ago (2017-01-24 21:06:00 UTC) #3
Siggi Cherem (dart-lang)
(very nice, btw!)
3 years, 11 months ago (2017-01-24 21:06:13 UTC) #4
Johnni Winther
https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/annotated_code_helper.dart File tests/compiler/dart2js/annotated_code_helper.dart (right): https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/annotated_code_helper.dart#newcode16 tests/compiler/dart2js/annotated_code_helper.dart:16: /// 0-based character offset with On 2017/01/24 21:05:59, Siggi ...
3 years, 11 months ago (2017-01-25 13:28:14 UTC) #5
Johnni Winther
3 years, 11 months ago (2017-01-25 13:44:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c885d809b6d65cbc1bd15289f5d1fc68f0acb090 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698