Add inference test functionality based on code point id.

Add inference test functionality based on code point id.

The code point id is meant to be basis for AST/Kernel-IR equivalence and the test framework should thereby be portable to a Kernel based inference.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/c885d809b6d65cbc1bd15289f5d1fc68f0acb090

[Johnni Winther, 2017-01-24 12:07:40]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Johnni Winther, 2017-01-24 12:07:41]

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/infe...
File tests/compiler/dart2js/inference/send_test.dart (right):

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/infe...
tests/compiler/dart2js/inference/send_test.dart:16: return
a.@{[exact=Sub]}method;
This test would have caught error in issue #27830.

[Siggi Cherem (dart-lang), 2017-01-24 21:06:00]

lgtm

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/anno...
File tests/compiler/dart2js/annotated_code_helper.dart (right):

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/anno...
tests/compiler/dart2js/annotated_code_helper.dart:16: /// 0-based character
offset with
with => of the annotation?

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/anno...
tests/compiler/dart2js/annotated_code_helper.dart:25: class AnnotatedCode {
add a short dart doc with an example of the syntax of the annotations

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/anno...
tests/compiler/dart2js/annotated_code_helper.dart:26: final String sourceCode;
+ dartdoc or rename to unannotatedCode?

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/anno...
tests/compiler/dart2js/annotated_code_helper.dart:32: AnnotatedCode
processAnnotatedCode(String code) {
optional nit: rename or move as a factory constructor of annotated code? Maybe:

  factory AnnotatedCode.parse(String annotatedCode) { ... }

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/anno...
tests/compiler/dart2js/annotated_code_helper.dart:57: case 0x40:
define 0x40 too?

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/infe...
File tests/compiler/dart2js/inference/enumerator.dart (right):

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/infe...
tests/compiler/dart2js/inference/enumerator.dart:46: case
SendStructureKind.INCOMPATIBLE_INVOKE:
any need to include SET too?

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/infe...
tests/compiler/dart2js/inference/enumerator.dart:47: case
SendStructureKind.INCOMPATIBLE_INVOKE:
remove dup?

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/infe...
File tests/compiler/dart2js/inference/inference_test_helper.dart (right):

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/infe...
tests/compiler/dart2js/inference/inference_test_helper.dart:100:
visitNode(node);
is this the same as super.visitSend(node);

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/infe...
File tests/compiler/dart2js/inference/send_test.dart (right):

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/infe...
tests/compiler/dart2js/inference/send_test.dart:8: const List<String> TESTS =
const <String>[
this would also be a great candidate for using package:testing... we should look
into it :)

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/sour...
File tests/compiler/dart2js/sourcemaps/stacktrace_test.dart (right):

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/sour...
tests/compiler/dart2js/sourcemaps/stacktrace_test.dart:209: return new
Test(annotatedCode.sourceCode /*codeBuffer.toString()*/,
remove comment :)

[Siggi Cherem (dart-lang), 2017-01-24 21:06:13]

(very nice, btw!)

[Johnni Winther, 2017-01-25 13:28:14]

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/anno...
File tests/compiler/dart2js/annotated_code_helper.dart (right):

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/anno...
tests/compiler/dart2js/annotated_code_helper.dart:16: /// 0-based character
offset with
On 2017/01/24 21:05:59, Siggi Cherem (dart-lang) wrote:
> with => of the annotation?

Done.

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/anno...
tests/compiler/dart2js/annotated_code_helper.dart:25: class AnnotatedCode {
On 2017/01/24 21:05:59, Siggi Cherem (dart-lang) wrote:
> add a short dart doc with an example of the syntax of the annotations

Done.

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/anno...
tests/compiler/dart2js/annotated_code_helper.dart:26: final String sourceCode;
On 2017/01/24 21:05:59, Siggi Cherem (dart-lang) wrote:
> + dartdoc or rename to unannotatedCode?

Done.

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/anno...
tests/compiler/dart2js/annotated_code_helper.dart:32: AnnotatedCode
processAnnotatedCode(String code) {
On 2017/01/24 21:05:59, Siggi Cherem (dart-lang) wrote:
> optional nit: rename or move as a factory constructor of annotated code?
Maybe:
> 
>   factory AnnotatedCode.parse(String annotatedCode) { ... }

Done.

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/infe...
File tests/compiler/dart2js/inference/enumerator.dart (right):

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/infe...
tests/compiler/dart2js/inference/enumerator.dart:46: case
SendStructureKind.INCOMPATIBLE_INVOKE:
On 2017/01/24 21:05:59, Siggi Cherem (dart-lang) wrote:
> any need to include SET too?

Not sure. I'm waiting for dartk to produce file offsets in Kernel IR. Currently
they use the offset of the left-hand side.

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/infe...
tests/compiler/dart2js/inference/enumerator.dart:47: case
SendStructureKind.INCOMPATIBLE_INVOKE:
On 2017/01/24 21:05:59, Siggi Cherem (dart-lang) wrote:
> remove dup?

Ok, then ;-)

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/infe...
File tests/compiler/dart2js/inference/inference_test_helper.dart (right):

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/infe...
tests/compiler/dart2js/inference/inference_test_helper.dart:100:
visitNode(node);
On 2017/01/24 21:05:59, Siggi Cherem (dart-lang) wrote:
> is this the same as super.visitSend(node);

Yes.

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/infe...
File tests/compiler/dart2js/inference/send_test.dart (right):

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/infe...
tests/compiler/dart2js/inference/send_test.dart:8: const List<String> TESTS =
const <String>[
On 2017/01/24 21:05:59, Siggi Cherem (dart-lang) wrote:
> this would also be a great candidate for using package:testing... we should
look
> into it :)

I know :)

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/sour...
File tests/compiler/dart2js/sourcemaps/stacktrace_test.dart (right):

https://codereview.chromium.org/2656583003/diff/1/tests/compiler/dart2js/sour...
tests/compiler/dart2js/sourcemaps/stacktrace_test.dart:209: return new
Test(annotatedCode.sourceCode /*codeBuffer.toString()*/,
On 2017/01/24 21:05:59, Siggi Cherem (dart-lang) wrote:
> remove comment :)

Done.

[Johnni Winther, 2017-01-25 13:44:36]

Description was changed from

==========
Add inference test functionality based on code point id.

The code point id is meant to be basis for AST/Kernel-IR equivalence and the
test framework should thereby be portable to a Kernel based inference.
==========

to

==========
Add inference test functionality based on code point id.

The code point id is meant to be basis for AST/Kernel-IR equivalence and the
test framework should thereby be portable to a Kernel based inference.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c885d809b6d65cbc1bd15289f5d1fc68f0acb090
==========

[Johnni Winther, 2017-01-25 13:44:38]

Committed patchset #2 (id:20001) manually as
c885d809b6d65cbc1bd15289f5d1fc68f0acb090 (presubmit successful).