Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2656503004: Revert "Remove package:unittest from some tests" (Closed)

Created:
3 years, 11 months ago by zra
Modified:
3 years, 11 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Remove package:unittest from some tests" This reverts commit dde47b2aad8629c7103905679b2c09762cb3581b. Revert "Update Dartium status for passing test" This reverts commit d71c70d56dee50c12c91d03627192e6ef93b8c7a. Tests failing on dart2js and async_star_pause_test is passing on Dartium. Need to think about how to update the status files. Committed: https://github.com/dart-lang/sdk/commit/63c4b6b1cbda3b7f5a5897d66b84f9ebe9695ac6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -182 lines) Patch
M tests/language/async_await_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M tests/language/async_star_pause_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/async_star_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/language.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/lib/async/first_regression_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/future_timeout_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/multiple_timer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/schedule_microtask2_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/lib/async/schedule_microtask3_test.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M tests/lib/async/schedule_microtask5_test.dart View 3 chunks +6 lines, -5 lines 0 comments Download
M tests/lib/async/stream_controller_async_test.dart View 29 chunks +44 lines, -43 lines 0 comments Download
M tests/lib/async/stream_first_where_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/lib/async/stream_from_iterable_test.dart View 8 chunks +14 lines, -13 lines 0 comments Download
M tests/lib/async/stream_iterator_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_join_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/lib/async/stream_last_where_test.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M tests/lib/async/stream_periodic2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_periodic3_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_periodic4_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_periodic5_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/lib/async/stream_periodic6_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_periodic_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_single_test.dart View 3 chunks +7 lines, -6 lines 0 comments Download
M tests/lib/async/stream_single_to_multi_subscriber_test.dart View 4 chunks +8 lines, -7 lines 0 comments Download
M tests/lib/async/stream_state_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_state_nonzero_timer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_state_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_subscription_as_future_test.dart View 9 chunks +14 lines, -13 lines 0 comments Download
M tests/lib/async/stream_subscription_cancel_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_transform_test.dart View 3 chunks +4 lines, -3 lines 0 comments Download
M tests/lib/async/stream_transformation_broadcast_test.dart View 15 chunks +29 lines, -28 lines 0 comments Download
M tests/lib/async/timer_cancel1_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/timer_cancel2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/timer_cancel_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/timer_isActive_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/timer_repeat_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/timer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/convert/json_lib_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/math/point_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/math/rectangle_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/mirrors/library_uri_io_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/mirrors/library_uri_package_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/sleep_test.dart View 2 chunks +14 lines, -24 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
3 years, 11 months ago (2017-01-25 19:06:28 UTC) #2
zra
TBR
3 years, 11 months ago (2017-01-25 19:06:52 UTC) #3
zra
Committed patchset #1 (id:1) manually as 63c4b6b1cbda3b7f5a5897d66b84f9ebe9695ac6 (presubmit successful).
3 years, 11 months ago (2017-01-25 19:07:03 UTC) #5
siva
3 years, 11 months ago (2017-01-25 21:21:46 UTC) #6
Message was sent while issue was closed.
lgtm.

I have added issue
https://github.com/dart-lang/sdk/issues/28514
for tracking the dart2js failures when this is submitted.

Powered by Google App Engine
This is Rietveld 408576698