tracing/tracing/metrics/system_health/long_tasks_metric.html - Issue 2656493002: Register metric Histogram names.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tracing/tracing/metrics/system_health/long_tasks_metric.html

Issue 2656493002: Register metric Histogram names. (Closed)

Patch Set: rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <!--	2 <!--

3 Copyright 2016 The Chromium Authors. All rights reserved.	3 Copyright 2016 The Chromium Authors. All rights reserved.

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7	7

8 <link rel="import" href="/tracing/extras/chrome/chrome_user_friendly_category_dr iver.html">	8 <link rel="import" href="/tracing/extras/chrome/chrome_user_friendly_category_dr iver.html">

9 <link rel="import" href="/tracing/metrics/metric_registry.html">	9 <link rel="import" href="/tracing/metrics/metric_registry.html">

10 <link rel="import" href="/tracing/model/helpers/chrome_model_helper.html">	10 <link rel="import" href="/tracing/model/helpers/chrome_model_helper.html">

(...skipping 85 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
96 values, 'long tasks ', slices,	96 values, 'long tasks ', slices,

97 e => (model.getUserFriendlyCategoryFromEvent(e) \|\| 'unknown'),	97 e => (model.getUserFriendlyCategoryFromEvent(e) \|\| 'unknown'),

98 tr.b.Unit.byName.timeDurationInMs_smallerIsBetter, sampleForEvent,	98 tr.b.Unit.byName.timeDurationInMs_smallerIsBetter, sampleForEvent,

99 tr.v.HistogramBinBoundaries.createExponential(1, LONGEST_TASK_MS, 40));	99 tr.v.HistogramBinBoundaries.createExponential(1, LONGEST_TASK_MS, 40));

100 breakdown.colorScheme =	100 breakdown.colorScheme =

101 tr.v.d.COLOR_SCHEME_CHROME_USER_FRIENDLY_CATEGORY_DRIVER;	101 tr.v.d.COLOR_SCHEME_CHROME_USER_FRIENDLY_CATEGORY_DRIVER;

102 longTaskHist.diagnostics.set('category', breakdown);	102 longTaskHist.diagnostics.set('category', breakdown);

103 }	103 }

104	104

105 tr.metrics.MetricRegistry.register(longTasksMetric, {	105 tr.metrics.MetricRegistry.register(longTasksMetric, {

106 supportsRangeOfInterest: true	106 supportsRangeOfInterest: true,

	107 histogramNames: new Set([]),

107 });	108 });

108	109

109 return {	110 return {

110 longTasksMetric,	111 longTasksMetric,

111 iterateLongTopLevelTasksOnThreadInRange,	112 iterateLongTopLevelTasksOnThreadInRange,

112 iterateRendererMainThreads,	113 iterateRendererMainThreads,

113 LONG_TASK_MS,	114 LONG_TASK_MS,

114 LONGEST_TASK_MS,	115 LONGEST_TASK_MS,

115 };	116 };

116 });	117 });

117 </script>	118 </script>

OLD	NEW