tracing/tracing/metrics/system_health/loading_metric.html - Issue 2656493002: Register metric Histogram names.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tracing/tracing/metrics/system_health/loading_metric.html

Issue 2656493002: Register metric Histogram names. (Closed)

Patch Set: rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tracing/tracing/metrics/system_health/estimated_input_latency_metric.html ('k') | tracing/tracing/metrics/system_health/long_tasks_metric.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <!--	2 <!--

3 Copyright 2016 The Chromium Authors. All rights reserved.	3 Copyright 2016 The Chromium Authors. All rights reserved.

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7	7

8 <link rel="import" href="/tracing/base/category_util.html">	8 <link rel="import" href="/tracing/base/category_util.html">

9 <link rel="import" href="/tracing/base/statistics.html">	9 <link rel="import" href="/tracing/base/statistics.html">

10 <link rel="import" href="/tracing/metrics/metric_registry.html">	10 <link rel="import" href="/tracing/metrics/metric_registry.html">

(...skipping 400 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
411 addSamplesToHistogram(firstInteractiveSamples,	411 addSamplesToHistogram(firstInteractiveSamples,

412 firstInteractiveHistogram);	412 firstInteractiveHistogram);

413 }	413 }

414	414

415 values.addHistogram(firstContentfulPaintHistogram);	415 values.addHistogram(firstContentfulPaintHistogram);

416 values.addHistogram(onLoadHistogram);	416 values.addHistogram(onLoadHistogram);

417 values.addHistogram(firstMeaningfulPaintHistogram);	417 values.addHistogram(firstMeaningfulPaintHistogram);

418 values.addHistogram(firstInteractiveHistogram);	418 values.addHistogram(firstInteractiveHistogram);

419 }	419 }

420	420

421 tr.metrics.MetricRegistry.register(loadingMetric);	421 tr.metrics.MetricRegistry.register(loadingMetric, {

	422 histogramNames: new Set([]),

	423 });

422	424

423 return {	425 return {

424 loadingMetric,	426 loadingMetric,

425 collectLoadingMetricsForRenderer,	427 collectLoadingMetricsForRenderer,

426 RESPONSIVENESS_THRESHOLD_MS,	428 RESPONSIVENESS_THRESHOLD_MS,

427 INTERACTIVE_WINDOW_SIZE_MS,	429 INTERACTIVE_WINDOW_SIZE_MS,

428 };	430 };

429 });	431 });

430 </script>	432 </script>

OLD	NEW