tracing/tracing/metrics/system_health/cpu_time_metric.html - Issue 2656493002: Register metric Histogram names.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tracing/tracing/metrics/system_health/cpu_time_metric.html

Issue 2656493002: Register metric Histogram names. (Closed)

Patch Set: rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tracing/tracing/metrics/system_health/clock_sync_latency_metric.html ('k') | tracing/tracing/metrics/system_health/estimated_input_latency_metric.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <!--	2 <!--

3 Copyright 2016 The Chromium Authors. All rights reserved.	3 Copyright 2016 The Chromium Authors. All rights reserved.

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7	7

8 <link rel="import" href="/tracing/metrics/metric_registry.html">	8 <link rel="import" href="/tracing/metrics/metric_registry.html">

9 <link rel="import" href="/tracing/model/helpers/chrome_model_helper.html">	9 <link rel="import" href="/tracing/model/helpers/chrome_model_helper.html">

10 <link rel="import" href="/tracing/model/helpers/chrome_renderer_helper.html">	10 <link rel="import" href="/tracing/model/helpers/chrome_renderer_helper.html">

(...skipping 90 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
101 max: false,	101 max: false,

102 min: false,	102 min: false,

103 std: false,	103 std: false,

104 sum: false	104 sum: false

105 });	105 });

106 cpuTimeHist.addSample(normalizedAllProcessCpuTime);	106 cpuTimeHist.addSample(normalizedAllProcessCpuTime);

107 values.addHistogram(cpuTimeHist);	107 values.addHistogram(cpuTimeHist);

108 }	108 }

109	109

110 tr.metrics.MetricRegistry.register(cpuTimeMetric, {	110 tr.metrics.MetricRegistry.register(cpuTimeMetric, {

111 supportsRangeOfInterest: true	111 supportsRangeOfInterest: true,

	112 histogramNames: new Set([]),

112 });	113 });

113	114

114 return {	115 return {

115 cpuTimeMetric,	116 cpuTimeMetric,

116 };	117 };

117 });	118 });

118 </script>	119 </script>

OLD	NEW