Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc

Issue 2656453002: Remove password manager's dependency of BrowsingDataHelper (Closed)
Patch Set: s/spec/possibly_invalid_spec/ Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
diff --git a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
index e4600c67248e5cea342a328419c19af82350b3aa..cdddb4508fd15001020702d0457fc84fdb485fa0 100644
--- a/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
+++ b/chrome/browser/ui/passwords/manage_passwords_ui_controller.cc
@@ -382,8 +382,8 @@ void ManagePasswordsUIController::NeverSavePasswordInternal() {
void ManagePasswordsUIController::UpdateBubbleAndIconVisibility() {
// If we're not on a "webby" URL (e.g. "chrome://sign-in"), we shouldn't
// display either the bubble or the icon.
- if (!BrowsingDataHelper::IsWebScheme(
- web_contents()->GetLastCommittedURL().scheme())) {
+ if (!ChromePasswordManagerClient::CanShowBubbleOnURL(
+ web_contents()->GetLastCommittedURL())) {
passwords_data_.OnInactive();
}
« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698