Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: chrome/common/chrome_constants_win_unittest.cc

Issue 2656443002: Use chrome::kChromeVersion in installer::GetModulePath(). (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "chrome/common/chrome_constants.h"
6
7 #include <memory>
8
9 #include "base/file_version_info.h"
10 #include "base/strings/utf_string_conversions.h"
11 #include "base/win/current_module.h"
12 #include "testing/gtest/include/gtest/gtest.h"
13
14 namespace chrome {
15
16 // Verify that |kChromeVersion| is equal to the version in the VS_VERSION_INFO
17 // resource of the current module.
18 TEST(ChromeConstants, ChromeVersion) {
19 std::unique_ptr<FileVersionInfo> file_version_info(
20 FileVersionInfo::CreateFileVersionInfoForModule(CURRENT_MODULE()));
grt (UTC plus 2) 2017/01/24 09:37:16 we want a test that will fail specifically if the
fdoray 2017/01/31 20:47:17 Done.
21 ASSERT_TRUE(file_version_info);
22 EXPECT_EQ(base::UTF16ToASCII(file_version_info->file_version()),
23 kChromeVersion);
24 }
25
26 } // namespace chrome
OLDNEW
« no previous file with comments | « no previous file | chrome/installer/util/module_util_win.cc » ('j') | chrome/installer/util/module_util_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698