ppapi/proxy/plugin_var_tracker.h - Issue 26564009: [PPAPI] It is now possible to pass filesystems from JavaScript to NaCl modules.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/proxy/plugin_var_tracker.h

Issue 26564009: [PPAPI] It is now possible to pass filesystems from JavaScript to NaCl modules. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Cleanup after refactor. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/pepper/host_var_tracker.cc ('K') | « content/renderer/pepper/resource_converter.cc ('k') | ppapi/proxy/plugin_var_tracker.cc » ('j') | ppapi/proxy/plugin_var_tracker.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ppapi/proxy/plugin_var_tracker.h

diff --git a/ppapi/proxy/plugin_var_tracker.h b/ppapi/proxy/plugin_var_tracker.h

index 126c8fcac59a9f48b9b836dcb881ba7fcecb952c..2f4e31f66ab5dc8ed6848d7d00567a0a649133a8 100644

--- a/ppapi/proxy/plugin_var_tracker.h

+++ b/ppapi/proxy/plugin_var_tracker.h

@@ -59,6 +59,10 @@ class PPAPI_PROXY_EXPORT PluginVarTracker : public VarTracker {

const PP_Var& host_object);

// VarTracker public overrides.

+ virtual PP_Var MakeResourcePPVar(const IPC::Message& creation_message,

raymes 2013/10/30 06:31:51 nit: I would put PP_Instance as the first param be

Matt Giuca 2013/10/30 07:00:39 Done.

+ int pending_renderer_id,

+ int pending_browser_id,

+ PP_Instance instance) OVERRIDE;

virtual ResourceVar* MakeResourceVar(PP_Resource pp_resource) OVERRIDE;

virtual void DidDeleteInstance(PP_Instance instance) OVERRIDE;

virtual int TrackSharedMemoryHandle(PP_Instance instance,

« content/renderer/pepper/host_var_tracker.cc ('K') | « content/renderer/pepper/resource_converter.cc ('k') | ppapi/proxy/plugin_var_tracker.cc » ('j') | ppapi/proxy/plugin_var_tracker.cc » ('J')