Issue 26564006: Cleanup: Add conversion interface for WebWidget derived classes.

Issue 26564006: Cleanup: Add conversion interface for WebWidget derived classes. (Closed)

Created:
7 years, 2 months ago by r.kasibhatla

Modified:
7 years, 2 months ago

Reviewers:
tkent

CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Cleanup: Add conversion interface for WebWidget derived classes. Adding toWebHelperPluginImpl, toWebPagePopupImpl & toWebPopupMenuImpl conversion functions to replace static_cast, which are derived from WebWidget. R=tkent BUG=None TEST=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159315

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -5 lines)			Patch
M	Source/web/ChromeClientImpl.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/web/WebHelperPluginImpl.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	Source/web/WebPagePopupImpl.h	View	1 2	2 chunks	+14 lines, -0 lines	0 comments	Download
M	Source/web/WebPopupMenuImpl.h	View	1	2 chunks	+14 lines, -0 lines	0 comments	Download
M	Source/web/WebViewImpl.cpp	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	public/web/WebWidget.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

tkent

https://codereview.chromium.org/26564006/diff/1/Source/web/WebPopupMenuImpl.h File Source/web/WebPopupMenuImpl.h (right): https://codereview.chromium.org/26564006/diff/1/Source/web/WebPopupMenuImpl.h#newcode89 Source/web/WebPopupMenuImpl.h:89: virtual bool isPagePopup() const OVERRIDE { return true; } ...

7 years, 2 months ago (2013-10-10 02:17:58 UTC) #2

r.kasibhatla

Simple copy-paste error. Sorry for overlook. https://codereview.chromium.org/26564006/diff/1/Source/web/WebPopupMenuImpl.h File Source/web/WebPopupMenuImpl.h (right): https://codereview.chromium.org/26564006/diff/1/Source/web/WebPopupMenuImpl.h#newcode89 Source/web/WebPopupMenuImpl.h:89: virtual bool isPagePopup() ...

7 years, 2 months ago (2013-10-10 04:22:41 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/26564006/5001

7 years, 2 months ago (2013-10-10 04:29:44 UTC) #5

commit-bot: I haz the power

Sorry for I got bad news for ya. Compile failed with a clobber build on ...

7 years, 2 months ago (2013-10-10 05:08:06 UTC) #6

tkent

https://codereview.chromium.org/26564006/diff/5001/Source/web/WebPagePopupImpl.h File Source/web/WebPagePopupImpl.h (right): https://codereview.chromium.org/26564006/diff/5001/Source/web/WebPagePopupImpl.h#newcode76 Source/web/WebPagePopupImpl.h:76: virtual bool isPagePopup() OVERRIDE { return true; } OVERRIDE ...

7 years, 2 months ago (2013-10-10 05:14:29 UTC) #7

r.kasibhatla

On 2013/10/10 05:14:29, tkent wrote: > https://codereview.chromium.org/26564006/diff/5001/Source/web/WebPagePopupImpl.h > File Source/web/WebPagePopupImpl.h (right): > > https://codereview.chromium.org/26564006/diff/5001/Source/web/WebPagePopupImpl.h#newcode76 > ...

7 years, 2 months ago (2013-10-10 05:54:31 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/26564006/7001

7 years, 2 months ago (2013-10-10 05:57:40 UTC) #9

Message was sent while issue was closed.

Change committed as 159315

Expand Messages | Collapse Messages