CQ: handle HTTP errors when accessing Rietveld

CQ: handle HTTP errors when accessing Rietveld

BUG=none
R=iannucci@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227843

[Paweł Hajdan Jr., 2013-10-09 01:45:27]

+Isaac

[iannucci, 2013-10-10 00:15:24]

lgtm

https://codereview.chromium.org/26564004/diff/1/commit-queue/tests/try_job_on...
File commit-queue/tests/try_job_on_rietveld_test.py (right):

https://codereview.chromium.org/26564004/diff/1/commit-queue/tests/try_job_on...
commit-queue/tests/try_job_on_rietveld_test.py:1003: [1.],
omg these tests are ridiculous.

https://codereview.chromium.org/26564004/diff/1/commit-queue/verification/try...
File commit-queue/verification/try_job_on_rietveld.py (right):

https://codereview.chromium.org/26564004/diff/1/commit-queue/verification/try...
commit-queue/verification/try_job_on_rietveld.py:781: 'not found?)\n%s' % e)
I would log this too.

I'm not sure if we can trust exceptions not to have sensitive data like
passwords 'n' stuff.

[Paweł Hajdan Jr., 2013-10-10 00:33:18]

https://codereview.chromium.org/26564004/diff/1/commit-queue/verification/try...
File commit-queue/verification/try_job_on_rietveld.py (right):

https://codereview.chromium.org/26564004/diff/1/commit-queue/verification/try...
commit-queue/verification/try_job_on_rietveld.py:781: 'not found?)\n%s' % e)
On 2013/10/10 00:15:24, iannucci wrote:
> I would log this too.
> 
> I'm not sure if we can trust exceptions not to have sensitive data like
> passwords 'n' stuff.

Done.

[Paweł Hajdan Jr., 2013-10-10 00:34:06]

Committed patchset #2 manually as r227843 (presubmit successful).