Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Issue 2656363003: Fix mocking native classes and add a regression test. (Closed)

Created:
3 years, 10 months ago by Jacob
Modified:
3 years, 10 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix mocking native classes and add a regression test. BUG= R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/c3870fc93f0ddfa672bc66f17d4e26d0a4aad06e

Patch Set 1 #

Patch Set 2 : Fix mocking native classes and add a regression test. #

Patch Set 3 : Fix mocking native classes and add a regression test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -4 lines) Patch
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 1 3 chunks +4 lines, -4 lines 0 comments Download
A tests/lib_strong/html/html_mock_test.dart View 1 2 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jacob
3 years, 10 months ago (2017-01-27 22:31:52 UTC) #2
vsm
lgtm!
3 years, 10 months ago (2017-01-27 22:33:30 UTC) #3
Jacob
3 years, 10 months ago (2017-01-27 22:34:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
c3870fc93f0ddfa672bc66f17d4e26d0a4aad06e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698