Add a temporary analyzer error to work around #28515

Add a temporary analyzer error to work around #28515

Analyzer summaries do not yet support generic function-typed
parameters.  To avoid user confusion, generate an error if the user
tries to use a generic function-typed parameter.

The error can be worked around by using a typedef or changing generic
types to `dynamic`.

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/c9b692e8d9e5d6217e73f1a892081cf0f482f3e5

[Paul Berry, 2017-01-27 18:01:53]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[scheglov, 2017-01-27 18:06:33]

LGTM

[Brian Wilkerson, 2017-01-27 19:37:05]

lgtm

https://codereview.chromium.org/2656303004/diff/1/pkg/analyzer/test/src/conte...
File pkg/analyzer/test/src/context/context_test.dart (right):

https://codereview.chromium.org/2656303004/diff/1/pkg/analyzer/test/src/conte...
pkg/analyzer/test/src/context/context_test.dart:2537: @failingTest //
TODO(paulberry): Remove when dartbug.com/28515 is fixed.
"Remove when" --> "Remove the annotation when"

[Paul Berry, 2017-01-29 15:28:57]

https://codereview.chromium.org/2656303004/diff/1/pkg/analyzer/test/src/conte...
File pkg/analyzer/test/src/context/context_test.dart (right):

https://codereview.chromium.org/2656303004/diff/1/pkg/analyzer/test/src/conte...
pkg/analyzer/test/src/context/context_test.dart:2537: @failingTest //
TODO(paulberry): Remove when dartbug.com/28515 is fixed.
On 2017/01/27 19:37:05, Brian Wilkerson wrote:
> "Remove when" --> "Remove the annotation when"

Done.

[Paul Berry, 2017-01-29 15:35:09]

Description was changed from

==========
Add a temporary analyzer error to work around #28515

Analyzer summaries do not yet support generic function-typed
parameters.  To avoid user confusion, generate an error if the user
tries to use a generic function-typed parameter.

The error can be worked around by using a typedef or changing generic
types to `dynamic`.
==========

to

==========
Add a temporary analyzer error to work around #28515

Analyzer summaries do not yet support generic function-typed
parameters.  To avoid user confusion, generate an error if the user
tries to use a generic function-typed parameter.

The error can be worked around by using a typedef or changing generic
types to `dynamic`.

R=brianwilkerson@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/c9b692e8d9e5d6217e73f1a892081cf0f482f3e5
==========

[Paul Berry, 2017-01-29 15:35:10]

Committed patchset #1 (id:1) manually as
c9b692e8d9e5d6217e73f1a892081cf0f482f3e5 (presubmit successful).

[Paul Berry, 2017-01-29 21:41:55]

On 2017/01/29 15:35:10, Paul Berry wrote:
> Committed patchset #1 (id:1) manually as
> c9b692e8d9e5d6217e73f1a892081cf0f482f3e5 (presubmit successful).

Note: this CL introduced some test failures.  Fix is here:
https://codereview.chromium.org/2660773003/