Find Favicon in priority of icon_type.

chrome/browser/history/history_service.h

Index: chrome/browser/history/history_service.h
diff --git a/chrome/browser/history/history_service.h b/chrome/browser/history/history_service.h
index 6891f38e71498c86140cb025cf5bfcdd1afeb5a2..cef5e5a71c90102c6971dd23e11f630b0fd71a60 100644
--- a/chrome/browser/history/history_service.h
+++ b/chrome/browser/history/history_service.h
@@ -707,6 +707,24 @@ class HistoryService : public CancelableRequestProvider,
       const FaviconService::FaviconResultsCallback& callback,
       CancelableTaskTracker* tracker);
 
+  // Used by FaviconService to find the first icon whose width and height are
+  // greater than or equal to that of |minimum_size_in_pixels|. This searches

[pkotwicz, 2013/10/18 01:29:35]

Nit: Used by FaviconService to find the first favicon bitmap whose width and
height are greater than or equal to |minimum_size_in_pixel|.

I would rather use "favicon bitmap" instead of "icon" because "favicon bitmap"
has a very specific meaning while "icon" does not.

[michaelbai, 2013/10/18 04:37:02]

Done.

[michaelbai, 2013/10/18 04:37:02]

Done.

+  // for icons by IconType. Each element of |icon_types| is a bitmask of
+  // IconTypes indicating the types to search for.
+  // If the largest icon of first icon types given by |icon_types| is not

[pkotwicz, 2013/10/18 01:29:35]

Nit: of |icon_types|[0] is not larger than ...

[michaelbai, 2013/10/18 04:37:02]

Done.

+  // larger than |minimum_size_in_pixel|, the next icon types of
+  // |icon_types| will be searched and so on.
+  // If none icon is larger than |minimum_size_in_pixel|, the largest

[pkotwicz, 2013/10/18 01:29:35]

Nit: If no icon

[michaelbai, 2013/10/18 04:37:02]

Done.

+  // one of all icon types in |icon_types| is returned.
+  // This feature is especially useful when some types of icon is perfered as
+  // long as its size is larger than a specific value.
+  CancelableTaskTracker::TaskId GetLargestFaviconForURL(
+      const GURL& page_url,
+      const std::vector<int>& icon_types,
+      int minimum_size_in_pixels,
+      const FaviconService::FaviconResultsCallback& callback,
+      CancelableTaskTracker* tracker);
+
   // Used by the FaviconService to get the favicon bitmap which most closely
   // matches |desired_size_in_dip| and |desired_scale_factor| from the favicon
   // with |favicon_id| from the history backend. If |desired_size_in_dip| is 0,