Find Favicon in priority of icon_type.

chrome/browser/history/history_service.h

Index: chrome/browser/history/history_service.h
diff --git a/chrome/browser/history/history_service.h b/chrome/browser/history/history_service.h
index 6891f38e71498c86140cb025cf5bfcdd1afeb5a2..d98c84293f3656d5c68f0c4782c5ed7d987ab40f 100644
--- a/chrome/browser/history/history_service.h
+++ b/chrome/browser/history/history_service.h
@@ -707,6 +707,22 @@ class HistoryService : public CancelableRequestProvider,
       const FaviconService::FaviconResultsCallback& callback,
       CancelableTaskTracker* tracker);
 
+  // Used by the FaviconService to get largest icon of |page_url| in the order

[sky, 2013/10/16 13:27:16]

Used by FaviconService to find the first icon whose width and height are greater
than or equal to that of |minimum_size_in_pixels|. This searches for icons by
IconType. Each element of |icon_types| is a bitmask of IconTypes indicating the
types to search for.

I don't see you doing this part of your comment: "If none icon is larger than
|minimal_size_in_pixel|, the largest one of all icon types in |icon_types| is
returned." Am I missing something?

[michaelbai, 2013/10/16 18:17:05]

In the HistoryBackend::GetLargestFaviconForURL, the largest icon is stored in
largest_icon local variable and this will always be returned no matter its size.

+  // of icon types given by |icon_types|.
+  // if the largest icon of first icon types given by |icon_types| is not
+  // larger than |minimal_size_in_pixel|, the next icon types of
+  // |params.icon_types| will be searched and so on.
+  // If none icon is larger than |minimal_size_in_pixel|, the largest
+  // one of all icon types in |icon_types| is returned.
+  // This feature is especially useful when some types of icon is perfered as
+  // long as its size is larger than a specific value.
+  CancelableTaskTracker::TaskId GetLargestFaviconForURL(
+      const GURL& page_url,
+      const std::vector<int>& icon_types,
+      int minimal_size_in_pixels,
+      const FaviconService::FaviconResultsCallback& callback,
+      CancelableTaskTracker* tracker);
+
   // Used by the FaviconService to get the favicon bitmap which most closely
   // matches |desired_size_in_dip| and |desired_scale_factor| from the favicon
   // with |favicon_id| from the history backend. If |desired_size_in_dip| is 0,